Add build metrics report as artifact to cpp-build workflow #12750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
2 - In Progress
…df into exper-build-metrics-report
davidwendt
commented
Feb 17, 2023
|
Go to the At the bottom of the output should be the link to the Build Metrics Report: |
davidwendt
added
3 - Ready for Review
ajschmidt8
approved these changes
Feb 18, 2023
There was a problem hiding this comment.
Looks great @davidwendt.
We can merge this PR and then come back to remove the manual upload steps later after your other PR below is merged.
Appreciate your work on this.
I'd be interested in hearing your thoughts on centralizing sort_ninja_log.py so that other repositories can make use of these reports.
We could easily add that to our CI containers to make it available to all RAPIDS libs.
ajschmidt8
added a commit
to rapidsai/gha-tools
that referenced
this pull request
Feb 18, 2023
Adds `rapids-upload-artifacts-dir` utility script for uploading individual files from the `RAPIDS_ARTIFACTS_DIR` directory. References: rapidsai/shared-workflows#42 rapidsai/cudf#12750 --------- Co-authored-by: AJ Schmidt <[email protected]>
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the Build Metrics Report into the gitHub actions workflow by uploading a link to the generated report to the CI downloads S3 and publishes a link to the report in the build output.
A follow-on PR will provide a more direct mechanism for locating the report link.
Checklist