Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove now redundant cuda initialization #12758

Merged
merged 3 commits into from
Feb 21, 2023
Merged

Remove now redundant cuda initialization #12758

merged 3 commits into from
Feb 21, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Feb 11, 2023

Description

Prior to #11452 cuDF Python did not require CUDA for compilation. When libcudf was is found by CMake, however, it triggers a compilation of the C++ library, which does require CUDA for compilation. In order to support this behavior, we included some extra logic in cuDF's CMake to ensure that the appropriate CUDA architectures are compiled for (respecting the extra options like RAPIDS and NATIVE that rapids-cmake offers). However, with the merge of #11452 this conditional is now redundant because cuDF requires CUDA compilation unconditionally, so we can remove the extra code.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. CMake CMake build issue tech debt improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 11, 2023
@vyasr vyasr requested a review from a team as a code owner February 11, 2023 00:28
@vyasr vyasr self-assigned this Feb 11, 2023
@vyasr vyasr requested review from shwina and isVoid February 11, 2023 00:28
bdice
bdice approved these changes Feb 11, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Discussed offline with @vyasr and realized this cleanup was needed. 😄

@ajschmidt8
Copy link
Member

(updating branch to retrigger GHAs to test new sccache settings)

@vyasr
Copy link
Contributor Author

vyasr commented Feb 21, 2023

@gpucibot merge

@rapids-bot
Copy link

rapids-bot bot commented Feb 21, 2023

@vyasr, the @gpucibot merge command has been replaced with /merge.

Please re-comment this PR with /merge and use this new command in the future.

@vyasr
Copy link
Contributor Author

vyasr commented Feb 21, 2023

/merge

@rapids-bot rapids-bot bot merged commit a308b24 into rapidsai:branch-23.04 Feb 21, 2023
@vyasr vyasr deleted the fix/remove_optional_cuda_logic branch February 21, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@shwina shwina Awaiting requested review from shwina shwina is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@vyasr vyasr

Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vyasr @ajschmidt8 @bdice