Skip to content

Commit

Permalink
Remove now redundant cuda initialization (#12758)
Browse files Browse the repository at this point in the history
Prior to #11452 cuDF Python did not require CUDA for compilation. When libcudf was is found by CMake, however, it triggers a compilation of the C++ library, which does require CUDA for compilation. In order to support this behavior, we included some extra logic in cuDF's CMake to ensure that the appropriate CUDA architectures are compiled for (respecting the extra options like `RAPIDS` and `NATIVE` that `rapids-cmake` offers). However, with the merge of #11452 this conditional is now redundant because cuDF requires CUDA compilation unconditionally, so we can remove the extra code.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)
  - AJ Schmidt (https://github.com/ajschmidt8)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #12758
  • Loading branch information
vyasr authored Feb 21, 2023
1 parent 7da233b commit a308b24
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions python/cudf/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -72,15 +72,6 @@ endif()
include(rapids-cython)

if(NOT cudf_FOUND)
# TODO: This will not be necessary once we upgrade to CMake 3.22, which will pull in the required
# languages for the C++ project even if this project does not require those languages.
include(rapids-cuda)
rapids_cuda_init_architectures(cudf-python)
enable_language(CUDA)
# Since cudf only enables CUDA optionally we need to manually include the file that
# rapids_cuda_init_architectures relies on `project` including.
include("${CMAKE_PROJECT_cudf-python_INCLUDE}")

set(BUILD_TESTS OFF)
set(BUILD_BENCHMARKS OFF)

Expand Down

0 comments on commit a308b24

Please sign in to comment.