-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use test paths relative to package directory. #12751
Conversation
@ajschmidt8 I think the absolute paths must be interpreted correctly by CodeCov. In commit 002fba0, I changed the test paths but forgot to modify the path to |
@bdice Should we wait for codecov bot to comment the reports on this PR before merging? |
I don't know why the bot hasn't commented yet. I will merge in |
Hard to know what's wrong. @galipremsagar Can you tell? https://app.codecov.io/gh/rapidsai/cudf/pull/12751 |
The error shown in that page that base branch is missing is related to our nightly jobs not running probably. But the bot should have commented even if above is the case, lets wait and see if the bot comments in a bit. |
For reference, we generally don't enable nightly builds/tests for the next development branch until the release is complete. So |
/merge |
@bdice were the above issues with the codecov bot resolved? |
@vyasr I don't see Codecov bot PR comments on these recent PRs, so it's not related to the changes in this PR (which seemed fine, I verified them).
I don't know how to address this, it probably takes repo admin privileges if it's an issue with the application setup or webhooks. cc: @rapidsai/ops |
Description
This PR standardizes how our test paths are defined for dask-cudf and custreamz. This was originally a test to investigate a question related to CodeCov, which is answered below. We noticed that some coverage reports in the CI outputs used full paths like
/opt/conda/envs/test/lib/python3.10/site-packages/cudf/__init__.py
while other coverage reports gave relative paths likecudf/__init__.py
. The net result of this PR is that coverage reports are unchanged, but our CI tests are more correct because they always pull from the installed packages rather than the local packages (import dask_cudf
is fetching the built conda packages fromsite-packages
and not importing from the current path in the cloned repo).Checklist