Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split C++ and Python build dependencies into separate lists. #12724

Merged
merged 4 commits into from
Mar 6, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Feb 7, 2023

Description

This PR splits the build dependencies in dependencies.yaml into C++, Python, and shared (all) dependency lists. This makes it easier to understand the dependency tree for libcudf and cudf Python.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the conda label Feb 7, 2023
@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 7, 2023
@bdice bdice self-assigned this Feb 7, 2023
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.04@40e56c9). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 6c24fdc differs from pull request most recent head 00e29d1. Consider uploading reports for the commit 00e29d1 to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-23.04   #12724   +/-   ##
===============================================
  Coverage                ?   85.81%           
===============================================
  Files                   ?      158           
  Lines                   ?    25153           
  Branches                ?        0           
===============================================
  Hits                    ?    21586           
  Misses                  ?     3567           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdice bdice marked this pull request as ready for review March 2, 2023 00:29
@bdice bdice requested a review from a team as a code owner March 2, 2023 00:29
@bdice
Copy link
Contributor Author

bdice commented Mar 6, 2023

/merge

@rapids-bot rapids-bot bot merged commit b6d9fd1 into rapidsai:branch-23.04 Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants