Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug with num_keys in _scatter_by_slice #12749

Merged
merged 8 commits into from
Feb 17, 2023
Merged

Fix a bug with num_keys in _scatter_by_slice #12749

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1fdaccf
Fix it.
thomcom Feb 9, 2023
a450a1d
Add test
thomcom Feb 9, 2023
b57dba7
Use @wence-'s solution.
thomcom Feb 9, 2023
fcbf5ef
Style.
thomcom Feb 9, 2023
2082961
Merge branch 'branch-23.04' into bugfix/fix-_scatter_by_slice
thomcom Feb 14, 2023
e502164
Merge branch 'branch-23.04' into bugfix/fix-_scatter_by_slice
thomcom Feb 16, 2023
16c92f1
Merge branch 'branch-23.04' into bugfix/fix-_scatter_by_slice
thomcom Feb 17, 2023
3875b48
Merge branch 'branch-23.04' into bugfix/fix-_scatter_by_slice
thomcom Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/cudf/cudf/core/column/column.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,7 +607,7 @@ def _scatter_by_slice(
start, stop, step = key.indices(len(self))
if start >= stop:
return None
num_keys = (stop - start) // step
num_keys = len(range(start, stop, step))

self._check_scatter_key_length(num_keys, value)

Expand Down
10 changes: 10 additions & 0 deletions python/cudf/cudf/tests/test_setitem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,3 +347,13 @@ def test_series_setitem_upcasting_string_value():
assert_eq(pd.Series([10, 0, 0], dtype=int), sr)
with pytest.raises(ValueError):
sr[0] = "non-integer"


def test_scatter_by_slice_with_start_and_step():
source = pd.Series([1, 2, 3, 4, 5])
csource = cudf.from_pandas(source)
target = pd.Series([0, 0, 0, 0, 0, 0, 0, 0, 0, 0])
ctarget = cudf.from_pandas(target)
target[1::2] = source
ctarget[1::2] = csource
assert_eq(target, ctarget)