Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug with num_keys in _scatter_by_slice #12749

Merged
merged 8 commits into from
Feb 17, 2023
Merged

Fix a bug with num_keys in _scatter_by_slice #12749

merged 8 commits into from
Feb 17, 2023

Conversation

thomcom
Copy link
Contributor

@thomcom thomcom commented Feb 9, 2023 •
edited
Loading

Description

This PR closes #12748 by changing the num_keys computation in column._scatter_by_slice.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@thomcom thomcom requested a review from a team as a code owner February 9, 2023 17:07
@github-actions github-actions bot added the Python Affects Python cuDF API. label Feb 9, 2023
@thomcom
Copy link
Contributor Author

thomcom commented Feb 9, 2023

Did that

@thomcom thomcom added bug Something isn't working non-breaking Non-breaking change labels Feb 9, 2023
@thomcom thomcom mentioned this pull request Feb 16, 2023
Merged
3 tasks
@thomcom
Copy link
Contributor Author

thomcom commented Feb 16, 2023

This is ready to merge I think, and a PR in cuSpatial depends on it (rapidsai/cuspatial#926)

wence-
wence- approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I thought I had hit approve, but no. Looks great, thanks!

@wence-
Copy link
Contributor

wence- commented Feb 17, 2023

/merge

@rapids-bot rapids-bot bot merged commit b1aa5d2 into rapidsai:branch-23.04 Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice left review comments

@wence- wence- wence- approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@skirui-source skirui-source Awaiting requested review from skirui-source skirui-source is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Slice scatter assignment uses incorrect num_keys calculation
3 participants
@thomcom @wence- @bdice