Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default data source in cuio reader benchmarks #12740

Merged
merged 4 commits into from
Feb 10, 2023
Merged

Update default data source in cuio reader benchmarks #12740

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
37b0a41
Change default data source type in orc reader benchmark
PointKernel Feb 8, 2023
d5d0ae1
Merge remote-tracking branch 'upstream/branch-23.04' into orc-reader-…
PointKernel Feb 9, 2023
7a11dbf
Set DEVICE_BUFFER as default data source
PointKernel Feb 9, 2023
a4030db
Renaming: IOType instead of IO
PointKernel Feb 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/benchmarks/io/orc/orc_reader_input.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ void BM_orc_read_data(nvbench::state& state, nvbench::type_list<nvbench::enum_ty
data_profile_builder().cardinality(cardinality).avg_run_length(run_length));
auto const view = tbl->view();

cuio_source_sink_pair source_sink(io_type::HOST_BUFFER);
cuio_source_sink_pair source_sink(io_type::FILEPATH);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh, I didn't fully comprehend the proposed change until now.
I would argue that HOST_BUFFER is a better choice here (device buffer is the best option IMO) because this set of benchmarks is meant to benchmark only the decode part of the reader (the name is "orc_read_decode"). I understand that this leaves us with a gap in benchmark coverage (different types + IO). maybe that should either be a separate benchmark or an option.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @GregoryKimball

cudf::io::orc_writer_options opts =
cudf::io::orc_writer_options::builder(source_sink.make_sink_info(), view);

Expand Down