Update default data source in cuio reader benchmarks #12740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PointKernel
added
feature request
vuule
reviewed
Feb 9, 2023
| @@ -72,7 +72,7 @@ void BM_orc_read_data(nvbench::state& state, nvbench::type_list<nvbench::enum_ty | |||
| data_profile_builder().cardinality(cardinality).avg_run_length(run_length)); | |||
| auto const view = tbl->view(); | |||
|
|
|||
| cuio_source_sink_pair source_sink(io_type::HOST_BUFFER); | |||
| cuio_source_sink_pair source_sink(io_type::FILEPATH); | |||
There was a problem hiding this comment.
ooh, I didn't fully comprehend the proposed change until now.
I would argue that HOST_BUFFER is a better choice here (device buffer is the best option IMO) because this set of benchmarks is meant to benchmark only the decode part of the reader (the name is "orc_read_decode"). I understand that this leaves us with a gap in benchmark coverage (different types + IO). maybe that should either be a separate benchmark or an option.
|
But the issue#12678 says:
|
PointKernel
changed the title
vuule
approved these changes
Feb 9, 2023
ttnghia
reviewed
Feb 9, 2023
ttnghia
approved these changes
Feb 10, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12678
This PR sets the default data source in orc, parquet and csv reader benchmarks to
DEVICE_BUFFER.Description
Checklist