Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gpuCI scripts. #12712

Merged
merged 7 commits into from
Feb 11, 2023
Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Feb 6, 2023

Since migrating to GitHub Actions, the gpuCI scripts are no longer needed. This PR removes those outdated gpuCI scripts.

@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 6, 2023
@github-actions github-actions bot added the ci label Feb 6, 2023
@davidwendt
Copy link
Contributor

I would recommend keeping this files until all build features have been migrated to GitHub Actions since the scripts here would be useful to when enabling them. This includes the Build Metrics Report and the compute-sanitizer checks.

@github-actions github-actions bot added the conda label Feb 6, 2023
@bdice
Copy link
Contributor Author

bdice commented Feb 6, 2023

@davidwendt I'm tracking those tasks in a separate issue: https://github.com/rapidsai/ops/issues/2447#issuecomment-1343422135

If it's alright with you, I'd like to remove these files sooner than later (and refer back to previous branches as needed) because there is maintenance work like #12695, #12710 that is editing these unused files.

@bdice bdice marked this pull request as ready for review February 7, 2023 15:28
@bdice bdice requested a review from a team as a code owner February 7, 2023 15:28
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.04@1c0224f). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head d52618c differs from pull request most recent head c54b562. Consider uploading reports for the commit c54b562 to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-23.04   #12712   +/-   ##
===============================================
  Coverage                ?   85.81%           
===============================================
  Files                   ?      158           
  Lines                   ?    25146           
  Branches                ?        0           
===============================================
  Hits                    ?    21578           
  Misses                  ?     3568           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ajschmidt8
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 8630e7c into rapidsai:branch-23.04 Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants