[REVIEW] Pin dask and distributed for release
#12695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
3 - Ready for Review
This was referenced Feb 3, 2023
msadang
approved these changes
Feb 3, 2023
bdice
reviewed
Feb 3, 2023
conda/recipes/dask-cudf/run_test.sh
Outdated
| @@ -18,11 +18,11 @@ if [ "${ARCH}" = "aarch64" ]; then | |||
| fi | |||
|
|
|||
| # Install the latest version of dask and distributed | |||
| logger "pip install git+https://github.com/dask/distributed.git@main --upgrade --no-deps" | |||
| pip install "git+https://github.com/dask/distributed.git@main" --upgrade --no-deps | |||
| logger "pip install git+https://github.com/dask/[email protected] --upgrade --no-deps" | |||
There was a problem hiding this comment.
Should we update this file to use centralized bash logic that is more like the CI scripts?
# Dask & Distributed option to install main(nightly) or `conda-forge` packages.
export INSTALL_DASK_MAIN=0
# Dask version to install when `INSTALL_DASK_MAIN=0`
export DASK_STABLE_VERSION="2023.1.1"
There was a problem hiding this comment.
Yup, made the change 👍
bdice
reviewed
Feb 3, 2023
| @@ -35,7 +35,7 @@ export CONDA_BLD_DIR="$WORKSPACE/.conda-bld" | |||
|
|
|||
| # Whether to keep `dask/label/dev` channel in the env. If INSTALL_DASK_MAIN=0, | |||
| # `dask/label/dev` channel is removed. | |||
| export INSTALL_DASK_MAIN=1 | |||
| export INSTALL_DASK_MAIN=0 | |||
There was a problem hiding this comment.
FYI This file isn't being used anymore -- we just haven't had a chance to delete the gpuCI job scripts yet, since the GitHub Actions transition. I'm still fine with making changes here, but we won't have to do that anymore once the old scripts are deleted.
There was a problem hiding this comment.
Cool, thanks for the update 👍
bdice
approved these changes
Feb 3, 2023
Codecov ReportBase: 85.82% // Head: 85.82% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #12695 +/- ##
================================================
- Coverage 85.82% 85.82% -0.01%
================================================
Files 158 158
Lines 25184 25184
================================================
- Hits 21615 21614 -1
- Misses 3569 3570 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
rapids-bot bot
pushed a commit
to rapidsai/cuml
that referenced
this pull request
Feb 6, 2023
This PR pins `dask` and `distributed` to `2023.1.1` for `23.02` release. xref: rapidsai/cudf#12695 Authors: - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - Mark Sadang (https://github.com/msadang) - Dante Gama Dessavre (https://github.com/dantegd) URL: #5198
rapids-bot bot
pushed a commit
to rapidsai/raft
that referenced
this pull request
Feb 6, 2023
This PR pins `dask` and `distributed` to `2023.1.1` for `23.02` release. xref: rapidsai/cudf#12695 Authors: - GALI PREM SAGAR (https://github.com/galipremsagar) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Mark Sadang (https://github.com/msadang) - Corey J. Nolet (https://github.com/cjnolet) URL: #1242
rapids-bot bot
pushed a commit
to rapidsai/dask-cuda
that referenced
this pull request
Feb 6, 2023
This PR pins `dask` and `distributed` to `2023.1.1` for `23.02` release. xref: rapidsai/cudf#12695 Authors: - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - Mark Sadang (https://github.com/msadang) - Peter Andreas Entschev (https://github.com/pentschev) URL: #1106
pentschev
approved these changes
Feb 6, 2023
conda/recipes/dask-cudf/run_test.sh
Outdated
| @@ -18,11 +18,11 @@ if [ "${ARCH}" = "aarch64" ]; then | |||
| fi | |||
|
|
|||
| # Install the latest version of dask and distributed | |||
| logger "pip install git+https://github.com/dask/distributed.git@main --upgrade --no-deps" | |||
| pip install "git+https://github.com/dask/distributed.git@main" --upgrade --no-deps | |||
| logger "pip install git+https://github.com/dask/[email protected] --upgrade --no-deps" | |||
pentschev
approved these changes
Feb 6, 2023
There was a problem hiding this comment.
I've left a minor suggestion, but feel free to ignore. Otherwise LGTM, thanks so much @galipremsagar !
pentschev
approved these changes
Feb 6, 2023
raydouglass
pushed a commit
to rapidsai/cugraph
that referenced
this pull request
Feb 6, 2023
This PR pins `dask` and `distributed` to `2023.1.1` for `23.02` release. xref: rapidsai/cudf#12695 Authors: - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - Brad Rees (https://github.com/BradReesWork) - Jordan Jacobelli (https://github.com/Ethyling)
Merged
jakirkham
pushed a commit
to jakirkham/cuml
that referenced
this pull request
Feb 27, 2023
This PR pins `dask` and `distributed` to `2023.1.1` for `23.02` release. xref: rapidsai/cudf#12695 Authors: - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - Mark Sadang (https://github.com/msadang) - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#5198
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR pins
daskanddistributedto2023.1.1for23.02release.Checklist