Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert regex program java APIs and tests #12639

Merged

Conversation

cindyyuanjiang
Copy link
Contributor

@cindyyuanjiang cindyyuanjiang commented Jan 28, 2023

Description

Reverts #12548, #12625.
Due to test failures found in the spark-rapids side: NVIDIA/spark-rapids#7607.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the Java Affects Java cuDF API. label Jan 28, 2023
@jlowe jlowe added bug Something isn't working Spark Functionality that helps Spark RAPIDS non-breaking Non-breaking change labels Jan 29, 2023
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this is still marked as draft, but changes lgtm.

@cindyyuanjiang cindyyuanjiang marked this pull request as ready for review January 29, 2023 01:51
@cindyyuanjiang cindyyuanjiang requested a review from a team as a code owner January 29, 2023 01:51
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Base: 86.58% // Head: 85.82% // Decreases project coverage by -0.76% ⚠️

Coverage data is based on head (7fb6575) compared to base (b6dccb3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-23.02   #12639      +/-   ##
================================================
- Coverage         86.58%   85.82%   -0.76%     
================================================
  Files               155      158       +3     
  Lines             24368    25184     +816     
================================================
+ Hits              21098    21614     +516     
- Misses             3270     3570     +300     
Impacted Files Coverage Δ
python/cudf/cudf/_version.py 1.41% <0.00%> (-98.59%) ⬇️
python/cudf/cudf/core/buffer/spill_manager.py 72.50% <0.00%> (-7.50%) ⬇️
python/cudf/cudf/core/udf/utils.py 93.75% <0.00%> (-5.35%) ⬇️
python/cudf/cudf/io/json.py 87.35% <0.00%> (-4.71%) ⬇️
python/strings_udf/strings_udf/__init__.py 66.66% <0.00%> (-2.69%) ⬇️
python/cudf/cudf/utils/dtypes.py 77.85% <0.00%> (-1.61%) ⬇️
python/cudf/cudf/options.py 86.11% <0.00%> (-1.59%) ⬇️
python/cudf/cudf/core/single_column_frame.py 94.30% <0.00%> (-1.27%) ⬇️
...ython/custreamz/custreamz/tests/test_dataframes.py 98.38% <0.00%> (-1.01%) ⬇️
python/dask_cudf/dask_cudf/io/csv.py 96.34% <0.00%> (-1.00%) ⬇️
... and 57 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@msadang msadang merged commit f12d067 into rapidsai:branch-23.02 Jan 31, 2023
@cindyyuanjiang cindyyuanjiang deleted the revert-regex-program-code branch January 31, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] RegularExpressionTranspilerSuite exhibits multiple failures
4 participants