Revert "Fix leaks in ColumnVectorTest" #12634
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fb17ac7.
|
#12625 should not introduce any failure. Do you know the specific code in that PR that causes the test to fail? If the failure is indeed due to it then you should just fix that test, not reverse everything. |
|
I just realized that the failed tests are in spark-rapids. So I'm confused why changes in cudf tests could affect spark-rapids tests. |
@ttnghia We want to revert all PRs related to adding regex program APIs and tests and this is one of the PRs. I put up a new PR to revert all changes altogether, sorry about the confusion. |
|
Tracked by: #12639 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #12625.
Due to test failures in the spark-rapids side: NVIDIA/spark-rapids#7607