-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin arrow 9 in testing dependencies to prevent conda solve issues #12377
Conversation
4b97c16
to
8dc0c28
Compare
Codecov ReportBase: 86.58% // Head: 86.57% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #12377 +/- ##
================================================
- Coverage 86.58% 86.57% -0.01%
================================================
Files 155 155
Lines 24368 24517 +149
================================================
+ Hits 21098 21225 +127
- Misses 3270 3292 +22
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. Note that this should be resolved by #12327.
@ajschmidt8 As expected, we'll need to do something similar to fix this for gpuCI (or we can simply disable gpuCI at this point!). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I added a quick workaround that should hopefully work for Jenkins. But yes, we will soon disable Jenkins at which point those scripts will be removed entirely.
this commit (hopefully) ensures that `pyarrow` version `10` never gets installed in the first place
even though `pytorch` was excluded from the `aarch64` dependency list prior to this commit, it was still getting installed as a transitive dependency. further, the version being installed was `pytorch=1.13.0`, which seemed to pull in other dependencies that weren't compatible with our environment
This reverts commit adba3c5.
@gpucibot merge |
Description
This pinning is necessary because other testing dependencies require arrow (currently, transformers has a transitive dependency on it) and don't include a pinning as strict as ours, resulting in a newer arrow package (arrow 10) being installed. When we attempt to install our cudf/libcudf packages in CI, it should be able to downgrade to arrow 9, but the downgrade fails because changes in arrow's package structure in arrow 10 include the creation of a new libarrow package (arrow-cpp was renamed to libarrow) and libarrow has no equivalent in arrow 9. As a result, conda does not see a way to downgrade it, and it also does not see a way to satisfy its dependencies if the rest of the arrow packages are downgraded to arrow 9 (because libarrow is tied to arrow 10 packages), so the conda solve fails.
The current changeset will fix Github Actions CI. We may need additional fixes in our Jenkins CI.
Checklist