Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Upgrade to arrow-10.0.1 #12327

Merged
merged 47 commits into from
Jan 3, 2023
Merged

[REVIEW] Upgrade to arrow-10.0.1 #12327

merged 47 commits into from
Jan 3, 2023

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Dec 7, 2022 •
edited
Loading

Description

This PR upgrades arrow to 10.0.1 in cudf

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar self-assigned this Dec 7, 2022
@github-actions github-actions bot added CMake CMake build issue conda Python Affects Python cuDF API. libcudf Affects libcudf (C++/CUDA) code. labels Dec 7, 2022
@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function breaking Breaking change and removed libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API. CMake CMake build issue conda labels Dec 7, 2022
@github-actions github-actions bot added CMake CMake build issue conda Python Affects Python cuDF API. libcudf Affects libcudf (C++/CUDA) code. labels Dec 13, 2022
@github-actions github-actions bot added the ci label Dec 13, 2022
jlowe
jlowe approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java approval

revans2
revans2 approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks looks good.

@ajschmidt8 ajschmidt8 mentioned this pull request Dec 20, 2022
Merged
@vyasr
Copy link
Contributor

vyasr commented Dec 21, 2022

Given the holidays, I'd recommend waiting to merge this until at least 2/3 of myself, Prem and Robert are available in case merging this breaks anything that needs fixing.

ajschmidt8
ajschmidt8 approved these changes Dec 30, 2022
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Jan 3, 2023
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8a1ff58 into rapidsai:branch-23.02 Jan 3, 2023
@ttnghia ttnghia mentioned this pull request Jan 3, 2023
Merged
rapids-bot bot pushed a commit that referenced this pull request Jan 3, 2023
@ttnghia
Fix compile issue with arrow 10 (#12465)
11e49d3 
Arrow has been upgraded to version 10 in #12327. Unfortunately the new Arrow version trigger new warnings that are treated as compile error:
```
_deps/arrow-src/cpp/src/arrow/result.h(263): error #2810-D: ignoring return value type with "nodiscard" attribute
```

This PR fixes that by temporarily disabling such warnings.

Authors:
  - Nghia Truong (https://github.com/ttnghia)

Approvers:
  - David Wendt (https://github.com/davidwendt)
  - Robert Maynard (https://github.com/robertmaynard)

URL: #12465
@vyasr vyasr mentioned this pull request May 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice left review comments

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@kkraus14 kkraus14 kkraus14 approved these changes

@revans2 revans2 revans2 approved these changes

@vyasr vyasr vyasr approved these changes

@jlowe jlowe jlowe approved these changes

@robertmaynard robertmaynard robertmaynard approved these changes

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge breaking Breaking change CMake CMake build issue improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@galipremsagar @vyasr @robertmaynard @jlowe @revans2 @kkraus14 @bdice @ajschmidt8