Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 10 minutes to cuDF #12114

Merged
merged 6 commits into from
Nov 28, 2022
Merged

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Nov 10, 2022

Description

Update the introductory documentation to take account of current best practices.
In particular, use compute judiciously on dask-cuDF objects, and explain why
we are doing so.

Closes #4665
Closes #4946
Closes #10614
Closes #11931

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@wence- wence- added 3 - Ready for Review Ready for review by team doc Documentation non-breaking Non-breaking change labels Nov 10, 2022
@wence- wence- requested review from vyasr and beckernick November 10, 2022 10:27
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.02@628cd4f). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-23.02   #12114   +/-   ##
===============================================
  Coverage                ?   88.26%           
===============================================
  Files                   ?      137           
  Lines                   ?    22586           
  Branches                ?        0           
===============================================
  Hits                    ?    19935           
  Misses                  ?     2651           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wence- wence- changed the base branch from branch-22.12 to branch-23.02 November 18, 2022 17:27
@wence-
Copy link
Contributor Author

wence- commented Nov 21, 2022

Think I addressed all the comments.

Copy link
Contributor

@galipremsagar galipremsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wence- for updating the notebook!

Co-authored-by: Ashwin Srinath <[email protected]>
@wence-
Copy link
Contributor Author

wence- commented Nov 28, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d02601a into rapidsai:branch-23.02 Nov 28, 2022
@wence- wence- deleted the wence/fix/10mins branch November 28, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team doc Documentation non-breaking Non-breaking change
Projects
None yet
5 participants