Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] string docs for basic regex actions #4946

Closed
lmeyerov opened this issue Apr 19, 2020 · 7 comments · Fixed by #12114
Closed

[DOC] string docs for basic regex actions #4946

lmeyerov opened this issue Apr 19, 2020 · 7 comments · Fixed by #12114
Labels
doc Documentation feature request New feature or request Python Affects Python cuDF API. strings strings issues (C++ and Python)

Comments

@lmeyerov
Copy link

Report incorrect documentation

Location of incorrect documentation

https://docs.rapids.ai/api/cudf/stable/search.html?q=search&check_keywords=yes&area=default#

Describe the problems or issues found in the documentation

Searching docs for search and match had no hits for the new methods. I expected docs that would guide us on:

  • String match
  • Regex match
  • How to get the first group out / NA
  • How to get a list of matches out
  • How to convert non-strings to strings and get matches out

Steps taken to verify documentation is incorrect

Slack

Suggested fix for documentation

  1. API method docs

  2. Include regex as part of the quick tutorials, esp. for the above actions of str/rgx match (bool/span), single/multiple groups (val), and non-str -> str.


@lmeyerov lmeyerov added Needs Triage Need team to review and classify doc Documentation labels Apr 19, 2020
@harrism harrism added bug Something isn't working and removed Needs Triage Need team to review and classify labels Apr 20, 2020
@kkraus14 kkraus14 added feature request New feature or request strings strings issues (C++ and Python) and removed bug Something isn't working labels Apr 23, 2020
@davidwendt
Copy link
Contributor

@harrism
Copy link
Member

harrism commented Jul 20, 2020

@davidwendt is there any action needed here?

@davidwendt
Copy link
Contributor

The description is asking for examples and tutorials on using regex. I don't think these exist.
I'm not sure if the request is for Python API documentation or libcudf doxygen examples(?) documentation.
I believe all of the Python docs have examples in their API but I don't think there is a general tutorial on using regex.
Also, I don't know how to improve the doc search feature (or if it should be improved for this).

@lmeyerov
Copy link
Author

There were two locations, afaict first is still outstanding and second is done:

  1. Initial intro, aiding both initial discoverability and providing a reference example: part of 10min to cudf

https://docs.rapids.ai/api/cudf/stable/10min.html

  1. Done: actual docs -- searching search/match now leads to series methods with examples

https://docs.rapids.ai/api/cudf/stable/api.html?highlight=match#cudf.core.column.string.StringMethods.match

@harrism
Copy link
Member

harrism commented Jul 21, 2020

OK, sounds like a Python doc request.

@harrism harrism added the Python Affects Python cuDF API. label Jul 21, 2020
@github-actions
Copy link

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

@GregoryKimball
Copy link
Contributor

GregoryKimball commented Jun 25, 2022

To clarify, this issue is requesting to add a regex example to the "10 min to cuDF and Dask-cuDF".

wence- added a commit to wence-/cudf that referenced this issue Nov 10, 2022
@wence- wence- mentioned this issue Nov 10, 2022
3 tasks
rapids-bot bot pushed a commit that referenced this issue Nov 28, 2022
Update the introductory documentation to take account of current best practices.
In particular, use `compute` judiciously on `dask-cuDF` objects, and explain why
we are doing so.

Closes #4665
Closes #4946
Closes #10614
Closes #11931

Authors:
  - Lawrence Mitchell (https://github.com/wence-)

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - Ashwin Srinath (https://github.com/shwina)

URL: #12114
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation feature request New feature or request Python Affects Python cuDF API. strings strings issues (C++ and Python)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants