-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose engine argument in dask_cudf.read_json #12101
Expose engine argument in dask_cudf.read_json #12101
Conversation
Codecov ReportBase: 88.05% // Head: 88.08% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #12101 +/- ##
================================================
+ Coverage 88.05% 88.08% +0.02%
================================================
Files 135 135
Lines 22057 22066 +9
================================================
+ Hits 19423 19436 +13
+ Misses 2634 2630 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor queries. Overall looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@gpucibot merge |
Description
Exposes the
engine
argument indask_cudf.read_json
, enablingdask_cudf.read_json(... engine="cudf_experimental")
for nested json data.TODO (
maybe this PR?):byte_range
parameter for local storage (similar to what is done indask_cudf.read_csv
). This would depend on byte_range support for JSON Lines format #12017 for nested json data.Checklist