Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose engine argument in dask_cudf.read_json #12101

Merged

Conversation

rjzamora
Copy link
Member

@rjzamora rjzamora commented Nov 9, 2022

Description

Exposes the engine argument in dask_cudf.read_json, enabling dask_cudf.read_json(... engine="cudf_experimental") for nested json data.

TODO (maybe this PR?):

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@rjzamora rjzamora added 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Nov 9, 2022
@rjzamora rjzamora requested a review from a team as a code owner November 9, 2022 03:46
@github-actions github-actions bot added the Python Affects Python cuDF API. label Nov 9, 2022
@rjzamora rjzamora added dask Dask issue improvement Improvement / enhancement to an existing function and removed Python Affects Python cuDF API. labels Nov 9, 2022
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Base: 88.05% // Head: 88.08% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (5a1833b) compared to base (7535f31).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 5a1833b differs from pull request most recent head 7bf96b5. Consider uploading reports for the commit 7bf96b5 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #12101      +/-   ##
================================================
+ Coverage         88.05%   88.08%   +0.02%     
================================================
  Files               135      135              
  Lines             22057    22066       +9     
================================================
+ Hits              19423    19436      +13     
+ Misses             2634     2630       -4     
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/backends.py 84.96% <100.00%> (+0.05%) ⬆️
python/dask_cudf/dask_cudf/io/tests/test_json.py 100.00% <100.00%> (ø)
python/strings_udf/strings_udf/__init__.py 84.31% <0.00%> (+7.84%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor queries. Overall looks good!

python/dask_cudf/dask_cudf/backends.py Outdated Show resolved Hide resolved
python/dask_cudf/dask_cudf/io/json.py Outdated Show resolved Hide resolved
python/dask_cudf/dask_cudf/io/json.py Outdated Show resolved Hide resolved
python/dask_cudf/dask_cudf/io/tests/test_json.py Outdated Show resolved Hide resolved
python/dask_cudf/dask_cudf/io/tests/test_json.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added the Python Affects Python cuDF API. label Nov 9, 2022
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rjzamora rjzamora added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Nov 9, 2022
@rjzamora
Copy link
Member Author

rjzamora commented Nov 9, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 6f78e74 into rapidsai:branch-22.12 Nov 9, 2022
@rjzamora rjzamora deleted the json-experimental-dask-cudf branch November 9, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge dask Dask issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants