byte_range support for JSON Lines format #12017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikeyann
added
feature request
Codecov ReportBase: 87.47% // Head: 88.14% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #12017 +/- ##
================================================
+ Coverage 87.47% 88.14% +0.66%
================================================
Files 133 135 +2
Lines 21826 22126 +300
================================================
+ Hits 19093 19503 +410
+ Misses 2733 2623 -110
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
karthikeyann
added
4 - Needs Review
elstehle
reviewed
Nov 16, 2022
elstehle
approved these changes
Nov 16, 2022
wence-
approved these changes
Nov 16, 2022
robertmaynard
approved these changes
Nov 16, 2022
karthikeyann
added
5 - Ready to Merge
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Dec 1, 2022
This issue was introduced in #12017 merged, which triggers compiler error on some systems: ``` ../tests/io/json_chunked_reader.cpp: In function 'std::vector<cudf::io::table_with_metadata> skeleton_for_parellel_chunk_reader(cudf::host_span<std::unique_ptr<cudf::io::datasource> >, const cudf::io::json_reader_options&, int32_t, rmm::cuda_stream_view, rmm::mr::device_memory_resource*)': ../tests/io/json_chunked_reader.cpp:78:19: error: loop variable '<structured bindings>' creates a copy from type 'const std::pair<int, int>' [-Werror=range-loop-construct] 78 | for (auto const [chunk_start, chunk_end] : record_ranges) { | ^~~~~~~~~~~~~~~~~~~~~~~~ ../tests/io/json_chunked_reader.cpp:78:19: note: use reference type to prevent copying 78 | for (auto const [chunk_start, chunk_end] : record_ranges) { | ^~~~~~~~~~~~~~~~~~~~~~~~ | & ``` Fixing it is just by following the compiler recommendation: "use reference type to prevent copying". Authors: - Nghia Truong (https://github.com/ttnghia) Approvers: - David Wendt (https://github.com/davidwendt) - Yunsong Wang (https://github.com/PointKernel) URL: #12280
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for byte_range to be used in nested JSON parser for JSON Lines format (newline delimited JSON http://ndjson.org/)
The record delimiter "New lines" are only expected at the end of each record. Newlines in middle of record or within quotes are not expected and will lead to unknown behaviour. The record delimiters are not context aware in this PR.
This PR provides libcudf APIs, Cython APIs and python tests to enable byte range support. This will allow dask to do distributed/segmented parsing of JSON.
No Dask changes
Addresses part of #11843
Depends on #12060
Checklist