-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix singleton-range __setitem__
edge case
#12075
Fix singleton-range __setitem__
edge case
#12075
Conversation
Only when copying a zero-length range can we afford to return the target column. Closes rapidsai#12073.
Precondition is that range indices have been sanitised.
8c87b98
to
ca2eba3
Compare
Codecov ReportBase: 87.47% // Head: 88.11% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #12075 +/- ##
================================================
+ Coverage 87.47% 88.11% +0.63%
================================================
Files 133 135 +2
Lines 21826 22100 +274
================================================
+ Hits 19093 19473 +380
+ Misses 2733 2627 -106
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@gpucibot merge |
Description
When trying to set a length-one range with a length-one array, an off-by-one error in
copying.copy_range
meant that the value was discarded. Fix that, and tidy up the semantics ofcopy_range
a little while we're here. Closes #12073.Checklist