Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behaviour of inplace for copy_range when range is empty. #12135

Open
wence- opened this issue Nov 14, 2022 · 0 comments
Open

Behaviour of inplace for copy_range when range is empty. #12135

wence- opened this issue Nov 14, 2022 · 0 comments
Labels
Python Affects Python cuDF API. question Further information is requested

Comments

@wence-
Copy link
Contributor

wence- commented Nov 14, 2022

In copying.copy_range we have an inplace=False/True argument.

If inplace is True, then the column is modified in place, if inplace is False, a new (copied) column is created and then modified. If the case that the range we are copying is empty, at present inplace=False still returns a new copy (even though copy_range is a no-op in this situation).

Should it be allowed that

copy_range(source, target, empty_range, inplace=False)

Can return target (rather than a copy of target)?

See discussion where this came p: #12075 (comment)

@wence- wence- added question Further information is requested Python Affects Python cuDF API. labels Nov 14, 2022
@vyasr vyasr added this to cuDF Python Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Python Affects Python cuDF API. question Further information is requested
Projects
Status: Todo
Development

No branches or pull requests

2 participants