Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Remove overflow error during decimal binops #12063

Merged
merged 2 commits into from
Nov 4, 2022

Conversation

galipremsagar
Copy link
Contributor

Description

Fixes: #11337

  • This PR removes raising of an overflow error and rather let's the data overflow similar to what we do with other numeric dtypes.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer labels Nov 3, 2022
@galipremsagar galipremsagar requested review from vyasr and shwina November 3, 2022 19:53
@galipremsagar galipremsagar self-assigned this Nov 3, 2022
@galipremsagar galipremsagar requested a review from a team as a code owner November 3, 2022 19:53
@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 3, 2022
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Nov 4, 2022
@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Base: 87.47% // Head: 88.09% // Increases project coverage by +0.62% 🎉

Coverage data is based on head (5fe8bfc) compared to base (f817d96).
Patch has no changes to coverable lines.

❗ Current head 5fe8bfc differs from pull request most recent head 7272685. Consider uploading reports for the commit 7272685 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #12063      +/-   ##
================================================
+ Coverage         87.47%   88.09%   +0.62%     
================================================
  Files               133      135       +2     
  Lines             21826    21999     +173     
================================================
+ Hits              19093    19381     +288     
+ Misses             2733     2618     -115     
Impacted Files Coverage Δ
python/cudf/cudf/io/text.py 91.66% <0.00%> (-8.34%) ⬇️
python/cudf/cudf/core/_base_index.py 81.28% <0.00%> (-4.27%) ⬇️
python/cudf/cudf/io/json.py 92.06% <0.00%> (-2.68%) ⬇️
python/cudf/cudf/utils/utils.py 89.91% <0.00%> (-0.69%) ⬇️
python/dask_cudf/dask_cudf/core.py 73.72% <0.00%> (-0.41%) ⬇️
python/cudf/cudf/io/parquet.py 90.45% <0.00%> (-0.39%) ⬇️
python/dask_cudf/dask_cudf/backends.py 84.90% <0.00%> (-0.37%) ⬇️
python/cudf/cudf/core/dataframe.py 93.63% <0.00%> (-0.10%) ⬇️
python/cudf/cudf/core/column/datetime.py 89.62% <0.00%> (-0.09%) ⬇️
python/cudf/cudf/io/orc.py 92.94% <0.00%> (-0.09%) ⬇️
... and 34 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b1c2520 into rapidsai:branch-22.12 Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]Decimal128 OverflowError BUG?
3 participants