Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strings like jni and native method #12032

Merged
merged 16 commits into from
Nov 3, 2022

Conversation

cindyyuanjiang
Copy link
Contributor

@cindyyuanjiang cindyyuanjiang commented Oct 31, 2022

rapidsai/cudf#11558 added strings like function to cudf, which is a wildcard-based string matching function based on SQL's LIKE statement.

We add like jni and native method calling the like function in #11558 and corresponding Java unit tests. This is part of the solution for issue NVIDIA/spark-rapids#6430.

@cindyyuanjiang cindyyuanjiang requested a review from a team as a code owner October 31, 2022 21:37
@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

1 similar comment
@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

@rapids-bot
Copy link

rapids-bot bot commented Oct 31, 2022

Pull requests from external contributors require approval from a rapidsai organization member with write or admin permissions before CI can begin.

@github-actions github-actions bot added the Java Affects Java cuDF API. label Oct 31, 2022
@ttnghia ttnghia added feature request New feature or request 3 - Ready for Review Ready for review by team Spark Functionality that helps Spark RAPIDS strings strings issues (C++ and Python) non-breaking Non-breaking change labels Nov 1, 2022
@sameerz sameerz linked an issue Nov 2, 2022 that may be closed by this pull request
@ttnghia
Copy link
Contributor

ttnghia commented Nov 2, 2022

ok to test

@msadang
Copy link
Contributor

msadang commented Nov 2, 2022

Ok to test

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 87.47% // Head: 88.11% // Increases project coverage by +0.63% 🎉

Coverage data is based on head (d0b0c02) compared to base (f817d96).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #12032      +/-   ##
================================================
+ Coverage         87.47%   88.11%   +0.63%     
================================================
  Files               133      135       +2     
  Lines             21826    21984     +158     
================================================
+ Hits              19093    19371     +278     
+ Misses             2733     2613     -120     
Impacted Files Coverage Δ
python/cudf/cudf/io/text.py 91.66% <0.00%> (-8.34%) ⬇️
python/cudf/cudf/core/_base_index.py 81.28% <0.00%> (-4.27%) ⬇️
python/cudf/cudf/io/json.py 92.06% <0.00%> (-2.68%) ⬇️
python/cudf/cudf/utils/utils.py 89.91% <0.00%> (-0.69%) ⬇️
python/dask_cudf/dask_cudf/core.py 73.72% <0.00%> (-0.41%) ⬇️
python/cudf/cudf/io/parquet.py 90.45% <0.00%> (-0.39%) ⬇️
python/dask_cudf/dask_cudf/backends.py 84.90% <0.00%> (-0.37%) ⬇️
python/cudf/cudf/core/column/datetime.py 89.62% <0.00%> (-0.09%) ⬇️
python/cudf/cudf/io/orc.py 92.94% <0.00%> (-0.09%) ⬇️
python/cudf/cudf/core/dataframe.py 93.67% <0.00%> (-0.06%) ⬇️
... and 34 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlowe
Copy link
Member

jlowe commented Nov 3, 2022

gpucibot merge

@jlowe
Copy link
Member

jlowe commented Nov 3, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit baa645d into rapidsai:branch-22.12 Nov 3, 2022
@cindyyuanjiang cindyyuanjiang deleted the like-operator branch November 3, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team feature request New feature or request Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS strings strings issues (C++ and Python)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] look into using the new CUDF like operator
6 participants