Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] look into using the new CUDF like operator #6430

Closed
revans2 opened this issue Aug 26, 2022 · 0 comments · Fixed by #6960 or rapidsai/cudf#12032
Closed

[FEA] look into using the new CUDF like operator #6430

revans2 opened this issue Aug 26, 2022 · 0 comments · Fixed by #6960 or rapidsai/cudf#12032
Assignees
@cindyyuanjiang
Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf performance A performance related task/issue

Comments

@revans2
Copy link
Collaborator

revans2 commented Aug 26, 2022

Is your feature request related to a problem? Please describe.
rapidsai/cudf#11558 was just merged into 22.10 for CUDF. We should try to switch over to it for the GpuLike operator, and test the performance of it compared to the existing solution and compared to the CPU implementation.
@revans2 revans2 added feature request New feature or request ? - Needs Triage Need team to review and classify labels Aug 26, 2022
@revans2 revans2 mentioned this issue Aug 26, 2022
Closed
@sameerz sameerz added performance A performance related task/issue and removed ? - Needs Triage Need team to review and classify feature request New feature or request labels Aug 30, 2022
@NVnavkumar NVnavkumar added the cudf_dependency An issue or PR with this label depends on a new feature in cudf label Oct 12, 2022
@cindyyuanjiang cindyyuanjiang self-assigned this Oct 18, 2022
@cindyyuanjiang cindyyuanjiang mentioned this issue Nov 1, 2022
Merged
@cindyyuanjiang cindyyuanjiang linked a pull request Nov 1, 2022 that will close this issue
Use cudf like operator in GpuLike operator #6960
Merged
@cindyyuanjiang cindyyuanjiang mentioned this issue Nov 2, 2022
Merged
@sameerz sameerz linked a pull request Nov 2, 2022 that will close this issue
Add strings like jni and native method rapidsai/cudf#12032
Merged
rapids-bot bot pushed a commit to rapidsai/cudf that referenced this issue Nov 3, 2022
@cindyyuanjiang
Add strings like jni and native method (#12032)
baa645d 
[#11558](#11558) added strings `like` function to cudf, which is a wildcard-based string matching function based on SQL's LIKE statement.

We add `like` jni and native method calling the `like` function in #11558 and corresponding Java unit tests. This is part of the solution for issue [NVIDIA/spark-rapids#6430](NVIDIA/spark-rapids#6430).

Authors:
  - Yuan Jiang (https://github.com/cindyyuanjiang)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - Gera Shegalov (https://github.com/gerashegalov)
  - Jason Lowe (https://github.com/jlowe)

URL: #12032
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cindyyuanjiang cindyyuanjiang

Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf performance A performance related task/issue
Projects
None yet
Milestone
No milestone
4 participants
@revans2 @sameerz @cindyyuanjiang @NVnavkumar