[Java] ArrowIPCTableWriter writes en empty batch in the case of an empty table. #11883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Liangcai Li <[email protected]>
firestarman
added
feature request
Codecov ReportBase: 87.40% // Head: 87.48% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #11883 +/- ##
================================================
+ Coverage 87.40% 87.48% +0.07%
================================================
Files 133 133
Lines 21833 21866 +33
================================================
+ Hits 19084 19129 +45
+ Misses 2749 2737 -12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ttnghia
approved these changes
Oct 8, 2022
Comment on lines
+7951
to
+7957
| boolean done = false; | ||
| int count = 0; | ||
| while (!done) { | ||
| try (Table t = reader.getNextIfAvailable()) { | ||
| if (t == null) { | ||
| done = true; | ||
| } else { |
There was a problem hiding this comment.
Nit: We can do this:
Suggested change
| boolean done = false; | |
| int count = 0; | |
| while (!done) { | |
| try (Table t = reader.getNextIfAvailable()) { | |
| if (t == null) { | |
| done = true; | |
| } else { | |
| int count = 0; | |
| while (true) { | |
| try (Table t = reader.getNextIfAvailable()) { | |
| if (t == null) { | |
| break; | |
| } else { |
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11882
Updated the
ArrowIPCTableWriterto write en empty batch explicitly in the case of an empty table, because the Arrow IPC writer will write no batches out for this case, leading to an error as below when calling thePyarrow.Table.from_batcheswithout specifying a schema.Signed-off-by: Liangcai Li [email protected]
Checklist