Support columnar processing for FlatMapCoGroupInPandas[databricks] #6751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: firestarman <[email protected]>
|
Draft due to missing the benchmark numbers, working on it now. |
Signed-off-by: Firestarman <[email protected]>
firestarman
changed the title
|
build |
|
It depends on rapidsai/cudf#11883, which was just merged. Wait for the latest jni jar to run the premerge CI. |
sameerz
added
the
task
|
build |
Signed-off-by: Firestarman <[email protected]>
|
build |
1 similar comment
|
build |
Signed-off-by: Firestarman <[email protected]>
|
build |
jlowe
approved these changes
Oct 13, 2022
| /** | ||
| * Python UDF Runner for cogrouped UDFs, designed for `GpuFlatMapCoGroupsInPandasExec` only. | ||
| * | ||
| * It sends Arrow bathes from two different DataFrames, groups them in Python, |
There was a problem hiding this comment.
Suggested change
| * It sends Arrow bathes from two different DataFrames, groups them in Python, | |
| * It sends Arrow batches from two different DataFrames, groups them in Python, |
There was a problem hiding this comment.
Nice catch, will update this in a following PR for issue #6778.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #305
This PR implements the columnar support for the
FlatMapCoGroupInPandasExec, along with some refactors.Performance
Signed-off-by: firestarman [email protected]