Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that minimum required CMake version is now 3.23.1 #11751

Merged

Conversation

robertmaynard
Copy link
Contributor

Description

With rapids-cmake now requiring CMake 3.23.1 update consumers to correctly express this requirement

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@robertmaynard robertmaynard added 3 - Ready for Review Ready for review by team doc Documentation non-breaking Non-breaking change labels Sep 23, 2022
@robertmaynard robertmaynard requested review from a team as code owners September 23, 2022 13:14
@robertmaynard robertmaynard requested review from a team as code owners September 23, 2022 13:14
@github-actions github-actions bot added CMake CMake build issue conda Java Affects Java cuDF API. Python Affects Python cuDF API. libcudf Affects libcudf (C++/CUDA) code. labels Sep 23, 2022
With rapids-cmake now requiring CMake 3.23.1 update consumers
to correctly express this requirement
@galipremsagar
Copy link
Contributor

rerun tests

@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.10@451c837). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-22.10   #11751   +/-   ##
===============================================
  Coverage                ?   87.52%           
===============================================
  Files                   ?      133           
  Lines                   ?    21774           
  Branches                ?        0           
===============================================
  Hits                    ?    19058           
  Misses                  ?     2716           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vyasr
Copy link
Contributor

vyasr commented Sep 27, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 466a90d into rapidsai:branch-22.10 Sep 27, 2022
@robertmaynard robertmaynard deleted the update_cmake_version branch September 27, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team CMake CMake build issue doc Documentation Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants