Skip to content

Commit

Permalink
Document that minimum required CMake version is now 3.23.1 (#11751)
Browse files Browse the repository at this point in the history
With rapids-cmake now requiring CMake 3.23.1 update consumers to correctly express this requirement

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - Ray Douglass (https://github.com/raydouglass)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #11751
  • Loading branch information
robertmaynard authored Sep 27, 2022
1 parent a270ae6 commit 466a90d
Show file tree
Hide file tree
Showing 13 changed files with 13 additions and 13 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ Compilers:

* `gcc` version 9.3+
* `nvcc` version 11.5+
* `cmake` version 3.20.1+
* `cmake` version 3.23.1+

CUDA/GPU:

Expand Down
2 changes: 1 addition & 1 deletion conda/environments/cudf_dev_cuda11.5.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ dependencies:
- clang-tools=11.1.0
- cupy>=9.5.0,<12.0.0a0
- rmm=22.10.*
- cmake>=3.20.1,!=3.23.0
- cmake>=3.23.1
- cmake_setuptools>=0.1.3
- scikit-build>=0.13.1
- python>=3.8,<3.10
Expand Down
2 changes: 1 addition & 1 deletion conda/recipes/cudf/conda_build_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ sysroot_version:
- "2.17"

cmake_version:
- ">=3.20.1,!=3.23.0"
- ">=3.23.1"

cuda_compiler:
- nvcc
2 changes: 1 addition & 1 deletion conda/recipes/cudf_kafka/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ build:

requirements:
build:
- cmake >=3.20.1,!=3.23.0
- cmake >=3.23.1
- {{ compiler('c') }}
- {{ compiler('cxx') }}
- sysroot_{{ target_platform }} {{ sysroot_version }}
Expand Down
2 changes: 1 addition & 1 deletion conda/recipes/libcudf/conda_build_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ sysroot_version:
- "2.17"

cmake_version:
- ">=3.20.1,!=3.23.0"
- ">=3.23.1"

gtest_version:
- "=1.10.0"
Expand Down
2 changes: 1 addition & 1 deletion conda/recipes/strings_udf/conda_build_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ sysroot_version:
- "2.17"

cmake_version:
- ">=3.20.1,!=3.23.0"
- ">=3.23.1"

cuda_compiler:
- nvcc
2 changes: 1 addition & 1 deletion cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# the License.
# =============================================================================

cmake_minimum_required(VERSION 3.20.1 FATAL_ERROR)
cmake_minimum_required(VERSION 3.23.1 FATAL_ERROR)

include(../fetch_rapids.cmake)
include(rapids-cmake)
Expand Down
2 changes: 1 addition & 1 deletion cpp/libcudf_kafka/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# or implied. See the License for the specific language governing permissions and limitations under
# the License.
# =============================================================================
cmake_minimum_required(VERSION 3.20.1 FATAL_ERROR)
cmake_minimum_required(VERSION 3.23.1 FATAL_ERROR)

include(../../fetch_rapids.cmake)
include(rapids-cmake)
Expand Down
2 changes: 1 addition & 1 deletion java/src/main/native/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# or implied. See the License for the specific language governing permissions and limitations under
# the License.
# =============================================================================
cmake_minimum_required(VERSION 3.20.1 FATAL_ERROR)
cmake_minimum_required(VERSION 3.23.1 FATAL_ERROR)

include(../../../../fetch_rapids.cmake)
include(rapids-cmake)
Expand Down
2 changes: 1 addition & 1 deletion python/cudf/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# the License.
# =============================================================================

cmake_minimum_required(VERSION 3.20.1 FATAL_ERROR)
cmake_minimum_required(VERSION 3.23.1 FATAL_ERROR)

set(cudf_version 22.10.00)

Expand Down
2 changes: 1 addition & 1 deletion python/cudf/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ requires = [
"setuptools",
"cython>=0.29,<0.30",
"scikit-build>=0.13.1",
"cmake>=3.20.1,!=3.23.0",
"cmake>=3.23.1",
"ninja",
]
2 changes: 1 addition & 1 deletion python/strings_udf/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# the License.
# =============================================================================

cmake_minimum_required(VERSION 3.20.1 FATAL_ERROR)
cmake_minimum_required(VERSION 3.23.1 FATAL_ERROR)

set(strings_udf_version 22.10.00)

Expand Down
2 changes: 1 addition & 1 deletion python/strings_udf/cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# the License.
# =============================================================================

cmake_minimum_required(VERSION 3.20.1)
cmake_minimum_required(VERSION 3.23.1)

include(rapids-cmake)
include(rapids-cpm)
Expand Down

0 comments on commit 466a90d

Please sign in to comment.