Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flake8 to 5.0.4 and use flake8-force to check Cython. #11736

Merged
merged 10 commits into from
Oct 18, 2022
6 changes: 4 additions & 2 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,14 @@ repos:
# Explicitly specify the pyproject.toml at the repo root, not per-project.
args: ["--config", "pyproject.toml"]
- repo: https://github.com/PyCQA/flake8
rev: 3.8.3
rev: 5.0.4
hooks:
- id: flake8
args: ["--config=setup.cfg"]
files: python/.*\.(py|pyx|pxd)$
files: python/.*$
types: [file]
types_or: [python, cython]
additional_dependencies: ["flake8-force"]
- repo: https://github.com/pre-commit/mirrors-mypy
rev: 'v0.971'
hooks:
Expand Down
8 changes: 1 addition & 7 deletions conda/environments/cudf_dev_cuda11.5.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,9 @@ dependencies:
- ipython
- pandoc<=2.0.0
- cudatoolkit=11.5
- cuda-python >=11.5,<11.7.1
- cuda-python>=11.5,<11.7.1
- pip
- flake8=3.8.3
vyasr marked this conversation as resolved.
Show resolved Hide resolved
- black=22.3.0
- isort=5.10.1
- mypy=0.971
- types-cachetools
- doxygen=1.8.20
- pydocstyle=6.1.1
- typing_extensions
- pre-commit
- dask>=2022.9.2
Expand Down
26 changes: 13 additions & 13 deletions python/cudf/cudf/_lib/cpp/io/avro.pxd
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2020, NVIDIA CORPORATION.
# Copyright (c) 2020-2022, NVIDIA CORPORATION.

from libcpp.string cimport string
from libcpp.vector cimport vector
Expand All @@ -11,31 +11,31 @@ cdef extern from "cudf/io/avro.hpp" \
namespace "cudf::io" nogil:

cdef cppclass avro_reader_options:
avro_reader_options() except+
cudf_io_types.source_info get_source() except+
vector[string] get_columns() except+
size_type get_skip_rows() except+
size_type get_num_rows() except+
avro_reader_options() except +
cudf_io_types.source_info get_source() except +
vector[string] get_columns() except +
size_type get_skip_rows() except +
size_type get_num_rows() except +

# setters

void set_columns(vector[string] col_names) except+
void set_skip_rows(size_type val) except+
void set_num_rows(size_type val) except+
void set_columns(vector[string] col_names) except +
void set_skip_rows(size_type val) except +
void set_num_rows(size_type val) except +

@staticmethod
avro_reader_options_builder builder(
cudf_io_types.source_info src
) except +

cdef cppclass avro_reader_options_builder:
avro_reader_options_builder() except+
avro_reader_options_builder() except +
avro_reader_options_builder(
cudf_io_types.source_info src
) except +
avro_reader_options_builder& columns(vector[string] col_names) except+
avro_reader_options_builder& skip_rows(size_type val) except+
avro_reader_options_builder& num_rows(size_type val) except+
avro_reader_options_builder& columns(vector[string] col_names) except +
avro_reader_options_builder& skip_rows(size_type val) except +
avro_reader_options_builder& num_rows(size_type val) except +

avro_reader_options build() except +

Expand Down
Loading