Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flake8 to 5.0.4 and use flake8-force to check Cython. #11736

Merged
merged 10 commits into from
Oct 18, 2022

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Sep 21, 2022

Description

Resolves #11684, required for eventually supporting Python 3.10 (which requires flake8 >= 4.0.0). flake8 >= 4.0.0, however, does not support parsing Cython code, even with rule exclusions. This necessitates the flake8-force plugin, which was designed (by a cupy developer) for forcing flake8 to check Cython code with a limited set of rules.

Per this comment (#11684 (comment)), this PR removes duplicate pinnings between pre-commit configuration and the developer conda environment. Developers should use pre-commit for style checks consistent with the CI environment.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the Python Affects Python cuDF API. label Sep 21, 2022
@bdice bdice changed the title Update flake8 Update flake8 to 5.0.4 and use flake8-force to check Cython. Sep 21, 2022
@bdice bdice self-assigned this Sep 21, 2022
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 87.40% // Head: 86.87% // Decreases project coverage by -0.53% ⚠️

Coverage data is based on head (279574b) compared to base (f72c4ce).
Patch coverage: 88.55% of modified lines in pull request are covered.

❗ Current head 279574b differs from pull request most recent head a312c71. Consider uploading reports for the commit a312c71 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #11736      +/-   ##
================================================
- Coverage         87.40%   86.87%   -0.54%     
================================================
  Files               133      133              
  Lines             21833    21905      +72     
================================================
- Hits              19084    19029      -55     
- Misses             2749     2876     +127     
Impacted Files Coverage Δ
python/cudf/cudf/core/dataframe.py 93.73% <ø> (-0.05%) ⬇️
python/cudf/cudf/core/indexed_frame.py 92.03% <ø> (ø)
python/cudf/cudf/core/udf/__init__.py 50.00% <ø> (ø)
python/cudf/cudf/io/orc.py 92.94% <ø> (-0.09%) ⬇️
python/cudf/cudf/testing/dataset_generator.py 72.83% <ø> (-0.42%) ⬇️
...thon/dask_cudf/dask_cudf/tests/test_distributed.py 18.86% <ø> (+4.94%) ⬆️
python/cudf/cudf/core/_base_index.py 82.20% <43.75%> (-3.35%) ⬇️
python/cudf/cudf/io/text.py 91.66% <66.66%> (-8.34%) ⬇️
python/strings_udf/strings_udf/__init__.py 84.31% <76.00%> (-12.57%) ⬇️
python/cudf/cudf/core/index.py 92.96% <95.71%> (+0.33%) ⬆️
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions github-actions bot added the conda label Sep 26, 2022
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two very minor quibbles (mostly just for discussion).

python/cudf/cudf/_lib/cpp/io/csv.pxd Show resolved Hide resolved
python/cudf/cudf/core/dataframe.py Show resolved Hide resolved
python/cudf/cudf/core/series.py Show resolved Hide resolved
python/cudf/cudf/core/dataframe.py Show resolved Hide resolved
python/cudf/cudf/core/dataframe.py Show resolved Hide resolved
@wence- wence- added the non-breaking Non-breaking change label Sep 27, 2022
@github-actions github-actions bot added CMake CMake build issue Java Affects Java cuDF API. gpuCI libcudf Affects libcudf (C++/CUDA) code. labels Oct 18, 2022
@bdice bdice changed the base branch from branch-22.10 to branch-22.12 October 18, 2022 15:13
@bdice bdice added improvement Improvement / enhancement to an existing function and removed gpuCI CMake CMake build issue Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code. labels Oct 18, 2022
@rapidsai rapidsai deleted a comment from review-notebook-app bot Oct 18, 2022
@bdice bdice marked this pull request as ready for review October 18, 2022 15:15
@bdice bdice requested review from a team as code owners October 18, 2022 15:15
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

@bdice
Copy link
Contributor Author

bdice commented Oct 18, 2022

rerun tests

Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@vyasr
Copy link
Contributor

vyasr commented Oct 18, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 425fb02 into rapidsai:branch-22.12 Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Update flake8 version in pre-commit
5 participants