Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate unflatten_nested_columns #11421

Merged
merged 7 commits into from
Aug 3, 2022
Merged

Deprecate unflatten_nested_columns #11421

merged 7 commits into from
Aug 3, 2022

Conversation

SrikarVanavasam
Copy link
Contributor

Closes #10952

After #10770 was merged there are no more uses of unflatten_nested_columns. This pr removes unflatten_nested_columns and adjusts the tests accordingly.

@SrikarVanavasam SrikarVanavasam requested a review from a team as a code owner August 1, 2022 20:19
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Aug 1, 2022
@SrikarVanavasam SrikarVanavasam added 3 - Ready for Review Ready for review by team tech debt non-breaking Non-breaking change libcudf Affects libcudf (C++/CUDA) code. and removed libcudf Affects libcudf (C++/CUDA) code. labels Aug 1, 2022
@SrikarVanavasam SrikarVanavasam changed the title Deprecate unflatten nested columns Deprecate unflatten_nested_columns Aug 1, 2022
@SrikarVanavasam SrikarVanavasam added the improvement Improvement / enhancement to an existing function label Aug 1, 2022
@codecov
Copy link

codecov bot commented Aug 1, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.10@df24808). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head bbcbe46 differs from pull request most recent head 8ce23f6. Consider uploading reports for the commit 8ce23f6 to get more accurate results

@@               Coverage Diff               @@
##             branch-22.10   #11421   +/-   ##
===============================================
  Coverage                ?   86.47%           
===============================================
  Files                   ?      144           
  Lines                   ?    22856           
  Branches                ?        0           
===============================================
  Hits                    ?    19765           
  Misses                  ?     3091           
  Partials                ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@SrikarVanavasam SrikarVanavasam requested a review from ttnghia August 2, 2022 16:19
@vyasr vyasr changed the base branch from branch-22.10 to branch-22.08 August 3, 2022 17:27
@vyasr vyasr requested review from a team as code owners August 3, 2022 17:27
@vyasr vyasr requested review from mroeschke and removed request for a team August 3, 2022 17:27
@vyasr vyasr changed the base branch from branch-22.08 to branch-22.10 August 3, 2022 17:27
@vyasr vyasr removed request for a team August 3, 2022 17:28
vyasr
vyasr approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch checker was frozen so I had to fiddle with the target to get it to run correctly. We should be good to go once tests pass again.

@vyasr
Copy link
Contributor

vyasr commented Aug 3, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit f31e5bd into rapidsai:branch-22.10 Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

@vyasr vyasr vyasr approved these changes

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke was automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Deprecate unflatten_nested_columns
4 participants
@SrikarVanavasam @vyasr @karthikeyann @ttnghia