-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update groupby::hash
to use new row operators for keys
#10770
Update groupby::hash
to use new row operators for keys
#10770
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10770 +/- ##
================================================
+ Coverage 86.28% 86.32% +0.03%
================================================
Files 144 144
Lines 22654 22668 +14
================================================
+ Hits 19548 19569 +21
+ Misses 3106 3099 -7
Continue to review full report at Codecov.
|
@mythrocks requesting your review as well since you authored the flattened nested column work. |
Setting the current work as breaking since the behavior is changed when nulls are excluded. See #10770 (comment) |
groupby::hash
to use new row operatorsgroupby::hash
to use new row operators for keys
rerun tests |
Wait, what? Why do we need to make these changes? I don't see these reflected in the top-level groupby API either. |
PR description updated to provide clearer breaking information. |
@gpucibot merge |
Closes #10952 After #10770 was merged there are no more uses of `unflatten_nested_columns`. This pr removes `unflatten_nested_columns` and adjusts the tests accordingly. Authors: - Srikar Vanavasam (https://github.com/SrikarVanavasam) Approvers: - Nghia Truong (https://github.com/ttnghia) - Karthikeyan (https://github.com/karthikeyann) - Vyas Ramasubramani (https://github.com/vyasr) URL: #11421
Related to #8039 and #10181
Contributes to #10186
This PR updates
groupby::hash
to use new row operators. It gets rid of the current "flattened nested column" logic and allowsgroupby::hash
to handleLIST
andSTRUCT
keys. The work also involves small cleanups like getting rid of unnecessary template parameters and removing unused arguments.It becomes a breaking PR since the updated
groupby::hash
will treat inner nulls as equal when top-level nulls are excludedwhile the current behavior treats inner nulls as unequal.