Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change file extension for groupby benchmark #10985

Merged
merged 4 commits into from
May 27, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions cpp/benchmarks/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -195,16 +195,16 @@ ConfigureBench(FILL_BENCH filling/repeat.cpp)
# * groupby benchmark -----------------------------------------------------------------------------
ConfigureBench(
GROUPBY_BENCH
groupby/group_sum.cu
groupby/group_nth.cu
groupby/group_shift.cu
groupby/group_sum.cpp
groupby/group_nth.cpp
groupby/group_shift.cpp
groupby/group_struct_values.cpp
groupby/group_no_requests.cu
groupby/group_scan.cu
groupby/group_rank_benchmark.cu
groupby/group_no_requests.cpp
groupby/group_scan.cpp
groupby/group_rank_benchmark.cpp
Copy link
Contributor

@bdice bdice May 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two requests:

  1. Can you also remove the word benchmark from this filename? It seems to have escaped Remove benchmarks suffix #10112.
  2. Why is this file listed in both the GBench and NVBench sections? I believe it is only an NVBench benchmark.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Done.
  2. I don't know exactly why, but believe that the _NVBench version output a very ugly result. The old _Bench version outputs a table that is very human readable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvbench be like 😭

)

ConfigureNVBench(GROUPBY_NVBENCH groupby/group_rank_benchmark.cu groupby/group_struct_keys.cpp)
ConfigureNVBench(GROUPBY_NVBENCH groupby/group_rank_benchmark.cpp groupby/group_struct_keys.cpp)

# ##################################################################################################
# * hashing benchmark -----------------------------------------------------------------------------
Expand Down