Change file extension for groupby benchmark #10985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttnghia
added
3 - Ready for Review
vuule
approved these changes
May 26, 2022
This comment was marked as off-topic.
This comment was marked as off-topic.
bdice
requested changes
May 27, 2022
cpp/benchmarks/CMakeLists.txt
Outdated
| groupby/group_rank_benchmark.cu | ||
| groupby/group_no_requests.cpp | ||
| groupby/group_scan.cpp | ||
| groupby/group_rank_benchmark.cpp |
There was a problem hiding this comment.
Two requests:
- Can you also remove the word
benchmarkfrom this filename? It seems to have escaped Remove benchmarks suffix #10112. - Why is this file listed in both the GBench and NVBench sections? I believe it is only an NVBench benchmark.
There was a problem hiding this comment.
- Done.
- I don't know exactly why, but believe that the
_NVBenchversion output a very ugly result. The old_Benchversion outputs a table that is very human readable.
bdice
approved these changes
May 27, 2022
|
@gpucibot merge |
codereport
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files in the groupby benchmark do not need to be in
.cuextension---they don't contain any device code. This PR changes them to the.cppextension.