Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SerializedTableHeader(numRows) public #10949

Conversation

gerashegalov
Copy link
Contributor

to be usable in different packages of spark-rapids to address
NVIDIA/spark-rapids#5513

Signed-off-by: Gera Shegalov [email protected]

to be usable in different packages of spark-rapids

Signed-off-by: Gera Shegalov <[email protected]>
@gerashegalov gerashegalov requested a review from a team as a code owner May 24, 2022 16:44
@github-actions github-actions bot added the Java Affects Java cuDF API. label May 24, 2022
@gerashegalov gerashegalov self-assigned this May 24, 2022
@gerashegalov gerashegalov added bug Something isn't working non-breaking Non-breaking change labels May 24, 2022
Signed-off-by: Gera Shegalov <[email protected]>
@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #10949 (bb4fec6) into branch-22.06 (54789ee) will increase coverage by 0.02%.
The diff coverage is 93.75%.

❗ Current head bb4fec6 differs from pull request most recent head 1c7690a. Consider uploading reports for the commit 1c7690a to get more accurate results

@@               Coverage Diff                @@
##           branch-22.06   #10949      +/-   ##
================================================
+ Coverage         86.30%   86.32%   +0.02%     
================================================
  Files               144      144              
  Lines             22665    22668       +3     
================================================
+ Hits              19560    19569       +9     
+ Misses             3105     3099       -6     
Impacted Files Coverage Δ
python/cudf/cudf/core/indexed_frame.py 91.70% <ø> (ø)
python/cudf/cudf/utils/ioutils.py 79.47% <87.50%> (-0.13%) ⬇️
python/cudf/cudf/io/avro.py 78.57% <100.00%> (ø)
python/cudf/cudf/io/csv.py 91.80% <100.00%> (ø)
python/cudf/cudf/io/json.py 97.56% <100.00%> (ø)
python/cudf/cudf/io/orc.py 92.77% <100.00%> (ø)
python/cudf/cudf/io/parquet.py 90.83% <100.00%> (ø)
python/cudf/cudf/io/text.py 100.00% <100.00%> (ø)
python/cudf/cudf/core/dataframe.py 93.78% <0.00%> (+0.04%) ⬆️
python/cudf/cudf/core/column/string.py 88.78% <0.00%> (+0.12%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da74744...1c7690a. Read the comment docs.

@gerashegalov
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 9f06de6 into rapidsai:branch-22.06 May 24, 2022
@gerashegalov gerashegalov deleted the public_SerializedTableHeader_numRows branch May 25, 2022 01:28
gerashegalov added a commit to NVIDIA/spark-rapids that referenced this pull request May 25, 2022
Don't use ai.rapidsai.cudf package for spark-rapids Scala classes. Otherwise it is going to be loaded by conventional classloader and fail to load referenced classes out of the shimmed areas.
- Move the class 
- add a smoking test to prevent this sort of regressions in premerge

Closes #5513. 

Depends on rapidsai/cudf#10949
    
Signed-off-by: Gera Shegalov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants