Move HostConcatResultUtil out of unshimmed classes #5614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't use ai.rapidsai.cudf package for spark-rapids Scala classes. Otherwise it is attempted to be loaded by conventional classloader Signed-off-by: Gera Shegalov <[email protected]>
gerashegalov
requested review from
jlowe,
revans2,
tgravescs,
GaryShen2008 and
NvTimLiu
as code owners
abellina
previously approved these changes
May 24, 2022
jlowe
previously approved these changes
May 24, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/cudf_utils/HostConcatResultUtil.scala
Show resolved
Hide resolved
Signed-off-by: Gera Shegalov <[email protected]>
jlowe
approved these changes
May 24, 2022
razajafri
reviewed
May 24, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/cudf_utils/HostConcatResultUtil.scala
Show resolved
Hide resolved
razajafri
reviewed
May 24, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/cudf_utils/HostConcatResultUtil.scala
Show resolved
Hide resolved
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't use ai.rapidsai.cudf package for spark-rapids Scala classes. Otherwise it is going to be loaded by conventional classloader and fail to load referenced classes out of the shimmed areas.
Closes #5513.
Depends on rapidsai/cudf#10949
Signed-off-by: Gera Shegalov [email protected]