Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in distinct: using nested nulls logic #10848

Merged
merged 3 commits into from
May 16, 2022

Conversation

PointKernel
Copy link
Member

This PR fixes a bug in cudf::distinct where the Nullate of the comparator should be determined by whether nested nulls are present.

@PointKernel PointKernel added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels May 13, 2022
@PointKernel PointKernel self-assigned this May 13, 2022
@PointKernel PointKernel requested a review from a team as a code owner May 13, 2022 13:46
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #10848 (760c4d5) into branch-22.06 (4ad1e51) will increase coverage by 0.02%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           branch-22.06   #10848      +/-   ##
================================================
+ Coverage         86.29%   86.32%   +0.02%     
================================================
  Files               144      144              
  Lines             22656    22656              
================================================
+ Hits              19552    19557       +5     
+ Misses             3104     3099       -5     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/numerical.py 95.88% <0.00%> (-0.30%) ⬇️
python/cudf/cudf/core/dataframe.py 93.78% <0.00%> (+0.04%) ⬆️
python/cudf/cudf/core/column/string.py 88.78% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.79% <0.00%> (+0.22%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/column/lists.py 91.70% <0.00%> (+0.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ad1e51...760c4d5. Read the comment docs.

@PointKernel
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d0d7193 into rapidsai:branch-22.06 May 16, 2022
@PointKernel PointKernel deleted the fix-distinct-bug branch May 16, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants