Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing cuda-python dependency to cudf #10833

Merged
merged 3 commits into from
May 11, 2022
Merged

Add missing cuda-python dependency to cudf #10833

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d3f857
Add cuda-python to install_requires, remove Cython (only a build syst…
bdice May 11, 2022
4f5145e
Standardize use of Cython build system requirement and definitions of…
bdice May 11, 2022
6112af7
Remove zip_safe=False.
bdice May 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions python/cudf/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,16 @@
import versioneer

install_requires = [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list was getting unwieldy so I sorted it. The only changes are removing Cython and adding cuda-python.

"numba>=0.53.1",
"Cython>=0.29,<0.30",
"cachetools",
"cuda-python>=11.5,<12.0",
"fsspec>=0.6.0",
"numba>=0.53.1",
"numpy",
"pandas>=1.0,<1.5.0dev0",
"typing_extensions",
"protobuf",
"nvtx>=0.2.1",
"cachetools",
"packaging",
"pandas>=1.0,<1.5.0dev0",
"protobuf",
"typing_extensions",
]

extras_require = {
Expand Down Expand Up @@ -259,6 +259,6 @@ def run(self):
),
cmdclass=cmdclass,
install_requires=install_requires,
zip_safe=False,
extras_require=extras_require,
zip_safe=False,
)
3 changes: 1 addition & 2 deletions python/cudf_kafka/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,9 @@
requires = [
"wheel",
"setuptools",
"Cython>=0.29,<0.30",
"cython>=0.29,<0.30",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Standardized this file to match cudf's pyproject.toml.

]


[tool.black]
line-length = 79
target-version = ["py36"]
Expand Down
5 changes: 3 additions & 2 deletions python/cudf_kafka/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@

install_requires = ["cudf", "cython"]

extras_require = {"test": ["pytest", "pytest-xdist"]}

cython_files = ["cudf_kafka/_lib/*.pyx"]

CUDA_HOME = os.environ.get("CUDA_HOME", False)
Expand Down Expand Up @@ -94,7 +96,6 @@
"Programming Language :: Python :: 3.9",
],
# Include the separately-compiled shared library
setup_requires=["Cython>=0.29,<0.30"],
ext_modules=cythonize(
extensions,
nthreads=nthreads,
Expand All @@ -109,6 +110,6 @@
),
cmdclass=versioneer.get_cmdclass(),
install_requires=install_requires,
extras_require={"test": ["pytest", "pytest-xdist"]},
extras_require=extras_require,
zip_safe=False,
)
4 changes: 3 additions & 1 deletion python/custreamz/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@

install_requires = ["cudf_kafka", "cudf"]

extras_require = {"test": ["pytest", "pytest-xdist"]}

setup(
name="custreamz",
version=versioneer.get_version(),
Expand All @@ -26,6 +28,6 @@
packages=find_packages(include=["custreamz", "custreamz.*"]),
cmdclass=versioneer.get_cmdclass(),
install_requires=install_requires,
extras_require=extras_require,
zip_safe=False,
extras_require={"test": ["pytest", "pytest-xdist"]},
)
1 change: 1 addition & 0 deletions python/dask_cudf/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,4 +91,5 @@ def get_cuda_version_from_header(cuda_include_dir, delimeter=""):
cmdclass=versioneer.get_cmdclass(),
install_requires=install_requires,
extras_require=extras_require,
zip_safe=False,
)