-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing cuda-python dependency to cudf #10833
Add missing cuda-python dependency to cudf #10833
Conversation
@@ -30,16 +30,16 @@ | |||
import versioneer | |||
|
|||
install_requires = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list was getting unwieldy so I sorted it. The only changes are removing Cython and adding cuda-python.
@@ -5,10 +5,9 @@ | |||
requires = [ | |||
"wheel", | |||
"setuptools", | |||
"Cython>=0.29,<0.30", | |||
"cython>=0.29,<0.30", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Standardized this file to match cudf's pyproject.toml
.
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10833 +/- ##
================================================
- Coverage 86.40% 86.31% -0.09%
================================================
Files 143 144 +1
Lines 22448 22648 +200
================================================
+ Hits 19396 19549 +153
- Misses 3052 3099 +47
Continue to review full report at Codecov.
|
@gpucibot merge |
This PR:
cuda-python
dependency to cudf'ssetup.py
. The package is used here (it is currently being supplied as a transitive dependency of RMM, but we should list all dependencies explicitly):cudf/python/cudf/cudf/utils/gpu_utils.py
Line 18 in 0cc29a0
pyproject.toml
, and never needed at runtime viainstall_requires
insetup.py
)extras_require
across all included Python packages