Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing cuda-python dependency to cudf #10833

Merged
merged 3 commits into from
May 11, 2022

Conversation

bdice
Copy link
Contributor

@bdice bdice commented May 11, 2022

This PR:

  • adds a missing cuda-python dependency to cudf's setup.py. The package is used here (it is currently being supplied as a transitive dependency of RMM, but we should list all dependencies explicitly):
    from cuda.cudart import cudaDeviceAttr, cudaError_t
  • standardizes declarations of Cython dependencies (it is only a build system dependency in pyproject.toml, and never needed at runtime via install_requires in setup.py)
  • standardizes definition of extras_require across all included Python packages

@bdice bdice self-assigned this May 11, 2022
@bdice bdice requested review from a team as code owners May 11, 2022 18:56
@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 11, 2022
@github-actions github-actions bot added the Python Affects Python cuDF API. label May 11, 2022
@@ -30,16 +30,16 @@
import versioneer

install_requires = [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list was getting unwieldy so I sorted it. The only changes are removing Cython and adding cuda-python.

@@ -5,10 +5,9 @@
requires = [
"wheel",
"setuptools",
"Cython>=0.29,<0.30",
"cython>=0.29,<0.30",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Standardized this file to match cudf's pyproject.toml.

@bdice bdice removed the request for review from a team May 11, 2022 19:00
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #10833 (2a82878) into branch-22.06 (8d861ce) will decrease coverage by 0.08%.
The diff coverage is 94.84%.

❗ Current head 2a82878 differs from pull request most recent head 6112af7. Consider uploading reports for the commit 6112af7 to get more accurate results

@@               Coverage Diff                @@
##           branch-22.06   #10833      +/-   ##
================================================
- Coverage         86.40%   86.31%   -0.09%     
================================================
  Files               143      144       +1     
  Lines             22448    22648     +200     
================================================
+ Hits              19396    19549     +153     
- Misses             3052     3099      +47     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/string.py 88.78% <ø> (-0.31%) ⬇️
python/cudf/cudf/core/frame.py 93.41% <ø> (ø)
python/cudf/cudf/core/indexed_frame.py 91.70% <ø> (ø)
python/cudf/cudf/io/__init__.py 100.00% <ø> (ø)
python/cudf/cudf/testing/testing.py 81.81% <50.00%> (+0.12%) ⬆️
python/cudf/cudf/io/parquet.py 90.83% <86.60%> (-1.87%) ⬇️
python/cudf/cudf/core/index.py 92.06% <88.88%> (-0.25%) ⬇️
python/cudf/cudf/core/scalar.py 89.01% <90.90%> (-0.31%) ⬇️
python/cudf/cudf/core/dataframe.py 93.78% <96.36%> (+0.08%) ⬆️
python/cudf/cudf/__init__.py 90.69% <100.00%> (+0.22%) ⬆️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cc29a0...6112af7. Read the comment docs.

@bdice
Copy link
Contributor Author

bdice commented May 11, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 1889133 into rapidsai:branch-22.06 May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants