Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for null scalar binaryops #10828

Merged
merged 1 commit into from
May 11, 2022
Merged

Add tests for null scalar binaryops #10828

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 37 additions & 2 deletions python/cudf/cudf/tests/test_binops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -902,7 +902,7 @@ def dtype_scalar(val, dtype):
return dtype.type(val)


def make_valid_scalar_add_data():
def make_scalar_add_data():
valid = set()

# to any int, we may add any kind of
Expand Down Expand Up @@ -968,7 +968,7 @@ def make_invalid_scalar_add_data():
return sorted(list(invalid))


@pytest.mark.parametrize("dtype_l,dtype_r", make_valid_scalar_add_data())
@pytest.mark.parametrize("dtype_l,dtype_r", make_scalar_add_data())
def test_scalar_add(dtype_l, dtype_r):
test_value = 1

Expand Down Expand Up @@ -1481,6 +1481,41 @@ def test_scalar_power_invalid(dtype_l, dtype_r):
lval_gpu**rval_gpu


def make_scalar_null_binops_data():
return (
[(operator.add, *dtypes) for dtypes in make_scalar_add_data()]
+ [(operator.sub, *dtypes) for dtypes in make_scalar_difference_data()]
+ [(operator.mul, *dtypes) for dtypes in make_scalar_product_data()]
+ [(operator.add, *dtypes) for dtypes in make_scalar_add_data()]
+ [
(operator.floordiv, *dtypes)
for dtypes in make_scalar_floordiv_data()
]
+ [
(operator.truediv, *dtypes)
for dtypes in make_scalar_truediv_data()
]
+ [(operator.mod, *dtypes) for dtypes in make_scalar_remainder_data()]
+ [(operator.pow, *dtypes) for dtypes in make_scalar_power_data()]
)


@pytest.mark.parametrize("op,dtype_l,dtype_r", make_scalar_null_binops_data())
def test_scalar_null_binops(op, dtype_l, dtype_r):
lhs = cudf.Scalar(cudf.NA, dtype=dtype_l)
rhs = cudf.Scalar(cudf.NA, dtype=dtype_r)

result = op(lhs, rhs)
assert result.value is cudf.NA

# make sure dtype is the same as had there been a valid scalar
valid_lhs = cudf.Scalar(0, dtype=dtype_l)
valid_rhs = cudf.Scalar(0, dtype=dtype_r)

valid_result = op(valid_lhs, valid_rhs)
assert result.dtype == valid_result.dtype


@pytest.mark.parametrize(
"date_col",
[
Expand Down