Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for null scalar binaryops #10828

Merged

Conversation

brandon-b-miller
Copy link
Contributor

Add tests for binaryops between two null scalars as per #10791 (comment)

This is technically 1307 tests but they only take about 5 seconds to run.

@brandon-b-miller brandon-b-miller added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 11, 2022
@brandon-b-miller brandon-b-miller requested a review from a team as a code owner May 11, 2022 14:24
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels May 11, 2022
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #10828 (248e5d9) into branch-22.06 (8d861ce) will decrease coverage by 0.08%.
The diff coverage is 92.09%.

@@               Coverage Diff                @@
##           branch-22.06   #10828      +/-   ##
================================================
- Coverage         86.40%   86.31%   -0.09%     
================================================
  Files               143      144       +1     
  Lines             22448    22648     +200     
================================================
+ Hits              19396    19549     +153     
- Misses             3052     3099      +47     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/lists.py 91.70% <ø> (-0.38%) ⬇️
python/cudf/cudf/core/column/string.py 88.78% <ø> (-0.31%) ⬇️
python/cudf/cudf/core/frame.py 93.41% <ø> (ø)
python/cudf/cudf/core/indexed_frame.py 91.70% <ø> (ø)
python/cudf/cudf/io/parquet.py 90.83% <82.55%> (-1.87%) ⬇️
python/cudf/cudf/core/index.py 92.06% <88.88%> (-0.25%) ⬇️
python/cudf/cudf/core/scalar.py 89.01% <90.90%> (-0.31%) ⬇️
python/cudf/cudf/core/dataframe.py 93.78% <96.15%> (+0.08%) ⬆️
python/cudf/cudf/__init__.py 90.69% <100.00%> (+0.22%) ⬆️
python/cudf/cudf/core/_compat.py 100.00% <100.00%> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19c5bad...248e5d9. Read the comment docs.

@galipremsagar
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 3e1a345 into rapidsai:branch-22.06 May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants