Change pattern parameter for regex APIs from std::string to std::string_view #10810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
2 - In Progress
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10810 +/- ##
================================================
+ Coverage 86.28% 86.31% +0.02%
================================================
Files 144 144
Lines 22654 22654
================================================
+ Hits 19548 19554 +6
+ Misses 3106 3100 -6
Continue to review full report at Codecov.
|
jrhemstad
approved these changes
May 9, 2022
davidwendt
added
3 - Ready for Review
bdice
approved these changes
May 12, 2022
There was a problem hiding this comment.
One suggestion - otherwise echoing @jrhemstad: 🚀 Small self-contained PRs! 🚀
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
May 19, 2022
…ew (#10832) Follow on to #10810. This changes other occurrences of parameter type `std::string` to `std::string_view` in the non-regex APIs. This covers `cudf::strings::pad` fill-char and the to/from-timestamp/duration converters that accept format specifiers. Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Mike Wilson (https://github.com/hyperbolic2346) - Bradley Dice (https://github.com/bdice) URL: #10832
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The input string pattern does not require a heavy-weight
std::stringobject but can accept astd::string_viewnow that we compile with c++17 for libcudf and cython. Literal strings (null-terminated char array),std::stringandstd::string_viewobjects can not be passed for thepatternparameter on these APIs.https://docs.rapids.ai/api/libcudf/stable/group__strings__contains.html
Although Cython does not have a native
libcpp.string_viewrepresentation, the Cython code works because thelibcpp.stringis automatically convertable to astd::string_view. However, the multi-pattern versionreplace_recould not be changed because Cython is unable to build astd::vector<std::string_view>instance at this time.Likewise, the Java code's
std::stringpattern parameters are automatically converted tostd::string_viewinstances.