-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cudf::strings::compute_regex_state_memory API #10808
Add cudf::strings::compute_regex_state_memory API #10808
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.08 #10808 +/- ##
===============================================
Coverage ? 86.34%
===============================================
Files ? 144
Lines ? 22729
Branches ? 0
===============================================
Hits ? 19625
Misses ? 3104
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From an API perspective, lgtm. The RAPIDS Accelerator can check for excessive memory usage or diminutive concurrent rows to decide when to avoid performing the regex processing on the GPU.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving ops-codeowner
file changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor nitpicks, but nothing over which to hold this PR.
I'm going to close this based on this comment: #10808 (comment) |
Add an API that returns the size of the state memory required to execute a specified regex pattern over a strings column. This is to help callers manage expected memory resource requirements for calling strings APIs that use libcudf's regex engine.