Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cudf::strings::compute_regex_state_memory API #10808

Closed

Conversation

davidwendt
Copy link
Contributor

Add an API that returns the size of the state memory required to execute a specified regex pattern over a strings column. This is to help callers manage expected memory resource requirements for calling strings APIs that use libcudf's regex engine.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 6, 2022
@davidwendt davidwendt self-assigned this May 6, 2022
@github-actions github-actions bot added the CMake CMake build issue label May 6, 2022
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@80d7cc7). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head b1ee09b differs from pull request most recent head fa45c23. Consider uploading reports for the commit fa45c23 to get more accurate results

@@               Coverage Diff               @@
##             branch-22.08   #10808   +/-   ##
===============================================
  Coverage                ?   86.34%           
===============================================
  Files                   ?      144           
  Lines                   ?    22729           
  Branches                ?        0           
===============================================
  Hits                    ?    19625           
  Misses                  ?     3104           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80d7cc7...fa45c23. Read the comment docs.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels May 9, 2022
@davidwendt davidwendt marked this pull request as ready for review May 9, 2022 16:05
@davidwendt davidwendt requested review from a team as code owners May 9, 2022 16:05
@davidwendt davidwendt requested review from mythrocks and ttnghia May 9, 2022 16:05
@davidwendt davidwendt requested a review from jlowe May 11, 2022 12:11
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From an API perspective, lgtm. The RAPIDS Accelerator can check for excessive memory usage or diminutive concurrent rows to decide when to avoid performing the regex processing on the GPU.

@davidwendt davidwendt requested a review from a team as a code owner May 19, 2022 18:39
@davidwendt davidwendt changed the base branch from branch-22.06 to branch-22.08 May 24, 2022 22:53
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nitpicks, but nothing over which to hold this PR.

cpp/src/strings/regex/config.cpp Outdated Show resolved Hide resolved
cpp/include/cudf/strings/regex/config.hpp Show resolved Hide resolved
cpp/tests/strings/regex_config_tests.cpp Show resolved Hide resolved
cpp/src/strings/regex/config.cpp Show resolved Hide resolved
@davidwendt
Copy link
Contributor Author

I'm going to close this based on this comment: #10808 (comment)
We can reopen this later if it becomes necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants