Skip to content

Commit

Permalink
change std::string parm to std::string_view
Browse files Browse the repository at this point in the history
  • Loading branch information
davidwendt committed Jun 23, 2022
1 parent 25bc135 commit fa45c23
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion cpp/include/cudf/strings/regex/config.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ namespace cudf::strings {
*/
std::pair<std::size_t, size_type> compute_regex_state_memory(
strings_column_view const& input,
std::string const& pattern,
std::string_view pattern,
regex_flags const flags = regex_flags::DEFAULT);

/** @} */ // end of doxygen group
Expand Down
6 changes: 3 additions & 3 deletions cpp/src/strings/regex/config.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -25,18 +25,18 @@ namespace cudf::strings {
namespace detail {

std::pair<std::size_t, size_type> compute_regex_state_memory(strings_column_view const& input,
std::string const& pattern,
std::string_view pattern,
regex_flags const flags,
rmm::cuda_stream_view stream)
{
auto d_prog = reprog_device::create(pattern, flags, stream);
auto const d_prog = reprog_device::create(pattern, flags, stream);
return d_prog->compute_strided_working_memory(input.size());
}

} // namespace detail

std::pair<std::size_t, size_type> compute_regex_state_memory(strings_column_view const& input,
std::string const& pattern,
std::string_view pattern,
regex_flags const flags)
{
CUDF_FUNC_RANGE();
Expand Down

0 comments on commit fa45c23

Please sign in to comment.