-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partial cuIO GPU decompression refactor #10699
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10699 +/- ##
================================================
+ Coverage 86.37% 86.43% +0.06%
================================================
Files 142 143 +1
Lines 22306 22444 +138
================================================
+ Hits 19266 19399 +133
- Misses 3040 3045 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The improvements from reviews made this PR look a lot better! I have some comments attached and will approve after some of the comments are addressed.
An apology in advance -- I attempted to find/fix some places where docstrings seemed to be marking inputs
as @param[out]
. While this may in fact be correct in some of the functions, I'm not sure that all the docstrings are correct -- and I'm also not sure if I correctly fixed all of the errors. Similarly, there are a few device_span<device_span<T const>>
that could probably be device_span<device_span<T const> const>
(with an extra const
on the outer span). I couldn't quite track all the functions' input/output patterns from what I saw in the diffs, and I decided it was not worth digging deeper to verify each one at the cost of delaying the review. I would suggest a very quick pass to double-check your expectations for const
ness of inputs/outputs/statuses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost through. Just a few minor comments and some nitpicks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your effort, @vuule! LGTM, once remaining comments are addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gpucibot merge |
Required to expand future nvcomp integration.
gpu_inflate_input_s
refactor to facilitate unified host/device decompressor interface. Enables further changes to unify CPU and GPU decompression API, which in turn enables ZSTD use in ORC.