Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Revert changes to nvcomp decompression status check in parquet #11065

Closed
devavret opened this issue Jun 7, 2022 · 3 comments
Closed

[FEA] Revert changes to nvcomp decompression status check in parquet #11065

devavret opened this issue Jun 7, 2022 · 3 comments
Labels
bug Something isn't working cuIO cuIO issue Performance Performance related issue

Comments

@devavret
Copy link
Contributor

devavret commented Jun 7, 2022

First discussed here: #11064 (review)

#10699 made a change to the decompression status check that reverted the changes made in #9995.
The latter added a custom kernel to check statuses to avoid using thrust::all_of which supposedly caused a device synchronize and deteriorated perf when running multiple parquet read calls on the same device.

This issue is to request the reverting of this particular change https://github.com/rapidsai/cudf/pull/10699/files#diff-69acbfcb0f4330a9fc3feec2aca0ceab2da0715fc1d7831304c2b154fb1a91e5L1053-L1083

@devavret devavret added feature request New feature or request Needs Triage Need team to review and classify labels Jun 7, 2022
@GregoryKimball GregoryKimball added Performance Performance related issue bug Something isn't working cuIO cuIO issue and removed feature request New feature or request Needs Triage Need team to review and classify labels Jun 28, 2022
@jbrennan333
Copy link
Contributor

I talked to @cheinger about this at our sync up today. He mentioned TPC-DS query 9 as one of the ones that was most affected by his optimization. Looking back at our spark-rapids weekly benchmarks, we don't see any degradation in q9 since #10699 went in. Based on what he said, it is not clear that we need to revert this change.

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@jbrennan333
Copy link
Contributor

@devavret, @vuule, do you agree this can be closed?

@vuule vuule closed this as completed Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cuIO cuIO issue Performance Performance related issue
Projects
None yet
Development

No branches or pull requests

4 participants