Fix rounding to zero error in stod on very small float numbers #10672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
bug
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10672 +/- ##
================================================
+ Coverage 86.38% 86.41% +0.02%
================================================
Files 142 142
Lines 22334 22334
================================================
+ Hits 19294 19300 +6
+ Misses 3040 3034 -6
Continue to review full report at Codecov.
|
bdice
reviewed
Apr 15, 2022
bdice
approved these changes
Apr 18, 2022
hyperbolic2346
approved these changes
Apr 22, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a rounding error on extremely small floating-point numbers in the range
1E-287 - 1E-307. These values were incorrectly being rounded to zero due to the fix in #10622. The extra float operation removed in #10622 is necessary for values in this range to keep them from being converted to zero.The fix adds a check so the extra floating point operation is only used when the overall exponent falls below
std::numeric_limits<double>::min_exponent10(which is-307). TheToFloat64gtest was also updated to include value in this range to ensure this error does not occur again.Additionally, the conversion now supports subnormal numbers that are very very small in the range of E-307 and E-324.