update comments

rapidsai · Apr 18, 2022 · a10e432 · a10e432
1 parent 958f3f9
commit a10e432
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/cpp/src/strings/convert/convert_floats.cu b/cpp/src/strings/convert/convert_floats.cu
@@ -128,8 +128,6 @@ __device__ inline double stod(string_view const& d_str)
     return sign > 0 ? std::numeric_limits<double>::infinity()
                     : -std::numeric_limits<double>::infinity();
   }
-  // else if (exp_ten < std::numeric_limits<double>::min_exponent10)
-  //  return double{0};
 
   double base = sign * static_cast<double>(digits);
 

diff --git a/cpp/tests/strings/floats_tests.cpp b/cpp/tests/strings/floats_tests.cpp
@@ -131,7 +131,7 @@ TEST_F(StringsConvertTest, ToFloats64)
     "-.002",  "",         "-0.0",     "1.28e256",      "NaN",     "abc123",
     "123abc", "456e",     "-1.78e+5", "-122.33644782", "12e+309", "1.7976931348623159E308",
     "-Inf",   "-INFINITY", "1.0",     "1.7976931348623157e+308",  "1.7976931348623157e-307",
-    // subnormal numbers
+    // subnormal numbers:           v--- smallest double               v--- result is 0
     "4e-308", "3.3333333333e-320", "4.940656458412465441765688e-324", "1.e-324" };
   // clang-format on
   cudf::test::strings_column_wrapper strings(