Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve User Guide docs #10663

Merged
merged 9 commits into from
Apr 14, 2022
Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Apr 14, 2022

This PR makes some minor improvements to the cuDF user guide and some docstrings.

@github-actions github-actions bot added the Python Affects Python cuDF API. label Apr 14, 2022
@bdice bdice marked this pull request as ready for review April 14, 2022 20:02
@bdice bdice requested a review from a team as a code owner April 14, 2022 20:02
@bdice bdice requested review from trxcllnt and rgsl888prabhu April 14, 2022 20:02
@bdice bdice self-assigned this Apr 14, 2022
@bdice bdice added doc Documentation non-breaking Non-breaking change labels Apr 14, 2022
@bdice
Copy link
Contributor Author

bdice commented Apr 14, 2022

@gpucibot merge

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Apr 14, 2022
@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #10663 (cce4cc8) into branch-22.06 (3c13ef1) will increase coverage by 0.03%.
The diff coverage is 89.62%.

@@               Coverage Diff                @@
##           branch-22.06   #10663      +/-   ##
================================================
+ Coverage         86.33%   86.37%   +0.03%     
================================================
  Files               140      142       +2     
  Lines             22289    22356      +67     
================================================
+ Hits              19244    19310      +66     
- Misses             3045     3046       +1     
Impacted Files Coverage Δ
python/cudf/cudf/core/algorithms.py 90.47% <ø> (ø)
python/cudf/cudf/core/cut.py 82.69% <ø> (ø)
python/cudf/cudf/core/groupby/groupby.py 91.72% <ø> (+0.22%) ⬆️
python/cudf/cudf/core/multiindex.py 92.14% <ø> (ø)
python/cudf/cudf/core/series.py 95.28% <ø> (ø)
python/cudf/cudf/utils/cudautils.py 59.83% <ø> (ø)
python/cudf/cudf/utils/ioutils.py 79.60% <ø> (ø)
python/cudf/cudf/utils/utils.py 90.28% <ø> (ø)
python/cudf/cudf/core/frame.py 93.67% <56.52%> (-1.09%) ⬇️
python/dask_cudf/dask_cudf/tests/utils.py 90.90% <90.90%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac27757...cce4cc8. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 14a3261 into rapidsai:branch-22.06 Apr 14, 2022
rapids-bot bot pushed a commit that referenced this pull request Apr 15, 2022
I noticed a couple lines I didn't expect in the UDF notebook in the User Guide while working on #10663. I didn't get these changes into that PR (had to wait for a local build to verify some things). The two changes are:
- We don't require `method="cudf"` in groupby statements.
- We don't need to execute `from cudf.utils import cudautils` to run this notebook.

(The cell execution counts also changed. There were some cells executed multiple times the last time this notebook was executed so they got out of order - this fixes it.)

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - https://github.com/brandon-b-miller

URL: #10668
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge doc Documentation non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants