-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve User Guide docs #10663
Merged
Merged
Improve User Guide docs #10663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
approved these changes
Apr 14, 2022
Co-authored-by: GALI PREM SAGAR <[email protected]>
galipremsagar
approved these changes
Apr 14, 2022
@gpucibot merge |
galipremsagar
added
the
5 - Ready to Merge
Testing and reviews complete, ready to merge
label
Apr 14, 2022
galipremsagar
approved these changes
Apr 14, 2022
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10663 +/- ##
================================================
+ Coverage 86.33% 86.37% +0.03%
================================================
Files 140 142 +2
Lines 22289 22356 +67
================================================
+ Hits 19244 19310 +66
- Misses 3045 3046 +1
Continue to review full report at Codecov.
|
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 15, 2022
I noticed a couple lines I didn't expect in the UDF notebook in the User Guide while working on #10663. I didn't get these changes into that PR (had to wait for a local build to verify some things). The two changes are: - We don't require `method="cudf"` in groupby statements. - We don't need to execute `from cudf.utils import cudautils` to run this notebook. (The cell execution counts also changed. There were some cells executed multiple times the last time this notebook was executed so they got out of order - this fixes it.) Authors: - Bradley Dice (https://github.com/bdice) Approvers: - https://github.com/brandon-b-miller URL: #10668
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
5 - Ready to Merge
Testing and reviews complete, ready to merge
doc
Documentation
non-breaking
Non-breaking change
Python
Affects Python cuDF API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some minor improvements to the cuDF user guide and some docstrings.