-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Fix some docstrings formatting #10660
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10660 +/- ##
================================================
+ Coverage 86.33% 86.37% +0.03%
================================================
Files 140 142 +2
Lines 22289 22356 +67
================================================
+ Hits 19244 19310 +66
- Misses 3045 3046 +1
Continue to review full report at Codecov.
|
@galipremsagar I have a complementary PR in progress - it doesn't overlap much with this one, but let me know if you plan to expand the scope of this PR. |
Thanks for taking care of this @galipremsagar |
I was looking to expand the scope, but thanks for letting me. Let's coordinate offline. |
@galipremsagar this looks good to me, but just to prevent any overzealous reviewers from reviewing prematurely before you and @bdice sort out PR scopes I've marked this as DO NOT MERGE. Feel free to ping if you need extra reviews/eyes. |
This is now ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks Prem!
Also: nice to learn about Sphinx's nitpick_ignore
.
@gpucibot merge |
This PR fixes some of the broken docstring formattings in the code-base.